linux-kernel - Re: [PATCH v2 0/3] Optimize the fast path of mas

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230613172352.u4oj5ydoloztvdqk@revolver>
Date:   Tue, 13 Jun 2023 13:23:52 -0400
From:   "Liam R. Howlett" <Liam.Howlett@...cle.com>
To:     Peng Zhang <zhangpeng.00@...edance.com>
Cc:     akpm@...ux-foundation.org, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org, maple-tree@...ts.infradead.org
Subject: Re: [PATCH v2 0/3] Optimize the fast path of mas_store()

* Peng Zhang <zhangpeng.00@...edance.com> [230609 08:04]:
> Add fast paths for mas_wr_append() and mas_wr_slot_store() respectively.
> The newly added fast path of mas_wr_append() is used in fork() and how
> much it benefits fork() depends on how many VMAs are duplicated.
> 
> Changes since v1:
>  - Revise comment and commit log. [3/3]
>  - Add test for mas_wr_modify() fast path. [1/3]

Thanks for adding the tests.  I'm just trying to figure out how to best
address testing this in RCU mode. And by testing it I mean add tests in
RCU that does this and detect the failure by modifying your code, then
change it back and have it pass the test by falling back to node store.
This would need to change tools/testing/radix-tree/maple.c to update the
testing there.

> 
> v1: https://lore.kernel.org/lkml/20230602075353.5917-1-zhangpeng.00@bytedance.com/
> 
> Peng Zhang (3):
>   maple_tree: add test for mas_wr_modify() fast path
>   maple_tree: optimize mas_wr_append(), also improve duplicating VMAs
>   maple_tree: add a fast path case in mas_wr_slot_store()
> 
>  lib/maple_tree.c      | 69 ++++++++++++++++++++++++++++---------------
>  lib/test_maple_tree.c | 65 ++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 111 insertions(+), 23 deletions(-)
> 
> -- 
> 2.20.1
>