linux-kernel - Re: [PATCH] spi: dw: Replace incorrect spi_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 13 Jun 2023 22:02:00 +0300
From:   Serge Semin <fancer.lancer@...il.com>
To:     Abe Kohandel <abe.kohandel@...el.com>
Cc:     linux-kernel@...r.kernel.org, linux-spi@...r.kernel.org,
        Mark Brown <broonie@...nel.org>,
        Amit Kumar Mahapatra <amit.kumar-mahapatra@....com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Subject: Re: [PATCH] spi: dw: Replace incorrect spi_get_chipselect with set

On Tue, Jun 13, 2023 at 09:21:03AM -0700, Abe Kohandel wrote:
> Commit 445164e8c136 ("spi: dw: Replace spi->chip_select references with
> function calls") replaced direct access to spi.chip_select with
> spi_*_chipselect calls but incorrectly replaced a set instance with a
> get instance, replace the incorrect instance.
> 
> Fixes: 445164e8c136 ("spi: dw: Replace spi->chip_select references with function calls")
> Signed-off-by: Abe Kohandel <abe.kohandel@...el.com>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

Indeed! Thanks for fixing this.
Acked-by: Serge Semin <fancer.lancer@...il.com>

-Serge(y)

> ---
>  drivers/spi/spi-dw-mmio.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/spi/spi-dw-mmio.c b/drivers/spi/spi-dw-mmio.c
> index a699ce496cc5..a963bc96c223 100644
> --- a/drivers/spi/spi-dw-mmio.c
> +++ b/drivers/spi/spi-dw-mmio.c
> @@ -292,7 +292,7 @@ static void dw_spi_elba_set_cs(struct spi_device *spi, bool enable)
>  	 */
>  	spi_set_chipselect(spi, 0, 0);
>  	dw_spi_set_cs(spi, enable);
> -	spi_get_chipselect(spi, cs);
> +	spi_set_chipselect(spi, 0, cs);
>  }
>  
>  static int dw_spi_elba_init(struct platform_device *pdev,
> -- 
> 2.40.1
>