linux-kernel - Re: [PATCH] sysctl: set variable sysctl_mount

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202306131330.AAC4C43AC@keescook>
Date:   Tue, 13 Jun 2023 13:30:47 -0700
From:   Kees Cook <keescook@...omium.org>
To:     Tom Rix <trix@...hat.com>
Cc:     mcgrof@...nel.org, yzaikin@...gle.com,
        linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH] sysctl: set variable sysctl_mount_point
 storage-class-specifier to static

On Sun, Jun 11, 2023 at 08:07:25AM -0400, Tom Rix wrote:
> smatch reports
> fs/proc/proc_sysctl.c:32:18: warning: symbol
>   'sysctl_mount_point' was not declared. Should it be static?
> 
> This variable is only used in its defining file, so it should be static.
> 
> Signed-off-by: Tom Rix <trix@...hat.com>

Reviewed-by: Kees Cook <keescook@...omium.org>

-- 
Kees Cook