linux-kernel - [PATCH v2 0/2] Fix srcline addr2line issue with the ',' sentinel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20230613034817.1356114-1-irogers@google.com>
Date:   Mon, 12 Jun 2023 20:48:15 -0700
From:   Ian Rogers <irogers@...gle.com>
To:     Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>,
        Ian Rogers <irogers@...gle.com>,
        Adrian Hunter <adrian.hunter@...el.com>,
        Nathan Chancellor <nathan@...nel.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Tom Rix <trix@...hat.com>, linux-perf-users@...r.kernel.org,
        linux-kernel@...r.kernel.org, llvm@...ts.linux.dev,
        Changbin Du <changbin.du@...wei.com>
Subject: [PATCH v2 0/2] Fix srcline addr2line issue with the ',' sentinel

addr2line makes it hard to detect when inline output has finished. To
detect it srcline issues a bogus ',' symbol and expects to see a
filename:line of "??:0". For binutils addr2line ',' gets turned into
address 0 and if there is a symbol there then the sentinel isn't
detected, this problem has been occurring with kernel binaries.

The issue was reported by and debugged by Changbin Du <changbin.du@...wei.com>.

v2. Incorporate feedback from Changbin.

Ian Rogers (2):
  perf srcline: Make addr2line configuration failure more verbose
  perf srcline: Make sentinel reading for binutils addr2line more robust

 tools/perf/util/srcline.c | 93 ++++++++++++++++++++++++++++++---------
 1 file changed, 73 insertions(+), 20 deletions(-)

-- 
2.41.0.162.gfafddb0af9-goog