linux-kernel - Re: [PATCH v2] block: fine-granular CAP_SYS_ADMIN for Persistent Reservation ioctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b89351eb-e450-61b9-53b6-02fe68319174@linux.alibaba.com>
Date:   Tue, 13 Jun 2023 14:02:18 +0800
From:   Jingbo Xu <jefflexu@...ux.alibaba.com>
To:     Christoph Hellwig <hch@....de>
Cc:     axboe@...nel.dk, linux-block@...r.kernel.org,
        linux-kernel@...r.kernel.org, tianjia.zhang@...ux.alibaba.com,
        xiang@...nel.org, casey@...aufler-ca.com
Subject: Re: [PATCH v2] block: fine-granular CAP_SYS_ADMIN for Persistent
 Reservation ioctl



On 6/13/23 1:02 PM, Christoph Hellwig wrote:
>> +static bool blkdev_pr_allowed(struct block_device *bdev, fmode_t mode)
> 
> With my resent series the use of fmode_t in the block layer has been
> replaced with a new blk_mode_t, so you'll need to rebase.

Okay I will rebase on that in the next version.

> 
>> +{
>> +	if (capable(CAP_SYS_ADMIN))
>> +		return true;
>> +
>> +	/* no sense to make reservations for partitions */
>> +	if (bdev_is_partition(bdev))
>> +		return false;
> 
> I think we should disallow the PR ioctls for partitions entirely.
> Yes, that's a change of behavior (and should be a separate patch),
> but this is the right time to fix it.

Okay I will make it into a separate patch later.


> Otherwise this change log good, thanks a lot!

Thanks for the comment and suggestions!


-- 
Thanks,
Jingbo