linux-kernel - Re: [PATCH] pinctrl: nxp: Fix resource leaks in for_each_child_of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <ZIgPl0UShltd0VEe@linux-8mug>
Date:   Tue, 13 Jun 2023 14:41:27 +0800
From:   Chester Lin <clin@...e.com>
To:     Markus Elfring <Markus.Elfring@....de>
Cc:     kernel-janitors@...r.kernel.org, s32@....com,
        linux-gpio@...r.kernel.org, opensource.kernel@...o.com,
        Linus Walleij <linus.walleij@...aro.org>,
        Lu Hongfei <luhongfei@...o.com>,
        LKML <linux-kernel@...r.kernel.org>, cocci@...ia.fr
Subject: Re: [PATCH] pinctrl: nxp: Fix resource leaks in
 for_each_child_of_node() loops

On Mon, Jun 12, 2023 at 04:01:00PM +0200, Markus Elfring wrote:
> > Ensure child node references are decremented properly in the error path.
> …
> > +++ b/drivers/pinctrl/nxp/pinctrl-s32cc.c
> > @@ -279,8 +279,10 @@ static int s32_dt_node_to_map(struct pinctrl_dev *pctldev,
> >  		ret = s32_dt_group_node_to_map(pctldev, np, map,
> >  					       &reserved_maps, num_maps,
> >  					       np_config->name);
> > -		if (ret < 0)
> > +		if (ret < 0) {
> > +			of_node_put(np);
> >  			break;
> > +		}
> >  	}
> >
> >  	if (ret)
> 
> May the same error predicate be applied at two places here?
> 

I think these two error predicates can be combined together in another patch.

Regards,
Chester

> Regards,
> Markus