linux-kernel - Re: [PATCH v3 3/8] dt-bindings: leds: leds-mt6323: Support WLED output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d8a09620-9891-8072-8602-403128ba8d30@linaro.org>
Date:   Tue, 13 Jun 2023 08:59:16 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>, pavel@....cz
Cc:     lee@...nel.org, sean.wang@...iatek.com, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, matthias.bgg@...il.com,
        linux-leds@...r.kernel.org, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org,
        kernel@...labora.com
Subject: Re: [PATCH v3 3/8] dt-bindings: leds: leds-mt6323: Support WLED
 output

On 09/06/2023 09:51, AngeloGioacchino Del Regno wrote:
> Il 02/06/23 10:32, Krzysztof Kozlowski ha scritto:
>> On 01/06/2023 13:08, AngeloGioacchino Del Regno wrote:
>>> Some PMICs have a separated WLED string output: add a property
>>> `mediatek,is-wled` to indicate which LED string is a WLED.
>>>
>>> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
>>> ---
>>>   Documentation/devicetree/bindings/leds/leds-mt6323.txt | 1 +
>>>   1 file changed, 1 insertion(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/leds/leds-mt6323.txt b/Documentation/devicetree/bindings/leds/leds-mt6323.txt
>>> index 052dccb8f2ce..904b2222a5fe 100644
>>> --- a/Documentation/devicetree/bindings/leds/leds-mt6323.txt
>>> +++ b/Documentation/devicetree/bindings/leds/leds-mt6323.txt
>>> @@ -30,6 +30,7 @@ Optional properties for the LED child node:
>>>   - label : See Documentation/devicetree/bindings/leds/common.txt
>>>   - linux,default-trigger : See Documentation/devicetree/bindings/leds/common.txt
>>>   - default-state: See Documentation/devicetree/bindings/leds/common.txt
>>> +- mediatek,is-wled: LED string is connected to WLED output
>>
>> Why would it matter to what the output is connected to?
> 
> When this property is present, the MT6323 LEDs are managed through different
> hardware registers which are specific to WLEDs: if we have no indication of
> whether this is a WLED or a LED, we would program the wrong registers.
> 

OK, so it is rather the choice of output in the device? What is "LED
string" in this context?


Best regards,
Krzysztof