linux-kernel - Re: [PATCH v4] cdx: Replace custom mcdi logging with print_hex_dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2023061300-mouth-suffering-8c20@gregkh>
Date:   Tue, 13 Jun 2023 09:40:32 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Abhijit Gangurde <abhijit.gangurde@....com>
Cc:     nikhil.agarwal@....com, Nipun.Gupta@....com, geert@...ux-m68k.org,
        linux-kernel@...r.kernel.org, git@....com, michal.simek@....com
Subject: Re: [PATCH v4] cdx: Replace custom mcdi logging with
 print_hex_dump_debug()

On Tue, Jun 13, 2023 at 12:22:31PM +0530, Abhijit Gangurde wrote:
> Replace custom mcdi logging for send and receive requests
> with dynamic debug method print_hex_dump_debug().
> 
> Fixes: eb96b740192b ("cdx: add MCDI protocol interface for firmware interaction")

This isn't a "fix", right?

> Signed-off-by: Abhijit Gangurde <abhijit.gangurde@....com>
> Closes: https://lore.kernel.org/lkml/CAMuHMdWTCdQagFFANygMgA8D0sWaoGxWv2AjibC3vwSd0UxuRw@mail.gmail.com/

This wasn't a "bug report" this was a "the code should be changed to not
do this" type of thing.  Part of normal development.

Other than those nits, looks good, want to fix this up and resend a v5?

thanks,

greg k-h