linux-kernel - Re: [PATCH] gpio: davinci: make davinci_gpio_dev_pm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMRc=Md9utfFY3Uimnn7XTiHma7GBBmKLPAc9Y735Mxt1McBWw@mail.gmail.com>
Date:   Tue, 13 Jun 2023 11:45:27 +0200
From:   Bartosz Golaszewski <brgl@...ev.pl>
To:     Min-Hua Chen <minhuadotchen@...il.com>
Cc:     Keerthy <j-keerthy@...com>,
        Linus Walleij <linus.walleij@...aro.org>,
        linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] gpio: davinci: make davinci_gpio_dev_pm_ops static

On Fri, Jun 9, 2023 at 2:16 PM Min-Hua Chen <minhuadotchen@...il.com> wrote:
>
> This patch fixes the following sprse warnings:
>
> drivers/gpio/gpio-davinci.c:695:1: sparse: warning: symbol 'davinci_gpio_dev_pm_ops' was not declared. Should it be static?
>
> No functional change intended.
>
> Signed-off-by: Min-Hua Chen <minhuadotchen@...il.com>
> ---
>  drivers/gpio/gpio-davinci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c
> index aaaf61dc2632..1aed3ace0240 100644
> --- a/drivers/gpio/gpio-davinci.c
> +++ b/drivers/gpio/gpio-davinci.c
> @@ -692,7 +692,7 @@ static int davinci_gpio_resume(struct device *dev)
>         return 0;
>  }
>
> -DEFINE_SIMPLE_DEV_PM_OPS(davinci_gpio_dev_pm_ops, davinci_gpio_suspend,
> +static DEFINE_SIMPLE_DEV_PM_OPS(davinci_gpio_dev_pm_ops, davinci_gpio_suspend,
>                          davinci_gpio_resume);
>
>  static const struct of_device_id davinci_gpio_ids[] = {
> --
> 2.34.1
>

Applied, thanks!

Bart