linux-kernel - Re: [PATCH v7] usb: common: usb-conn-gpio: Set last role to unknown before initial detection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2023061307-unguided-headboard-8ad7@gregkh>
Date:   Tue, 13 Jun 2023 11:58:14 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Prashanth K <quic_prashk@...cinc.com>
Cc:     AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v7] usb: common: usb-conn-gpio: Set last role to unknown
 before initial detection

On Wed, May 31, 2023 at 08:17:23PM +0530, Prashanth K wrote:
> 
> 
> On 31-05-23 08:11 pm, Prashanth K wrote:
> > diff --git a/drivers/usb/musb/jz4740.c b/drivers/usb/musb/jz4740.c
> > index 5aabdd7..6d880c4 100644
> > --- a/drivers/usb/musb/jz4740.c
> > +++ b/drivers/usb/musb/jz4740.c
> > @@ -95,6 +95,8 @@ static int jz4740_musb_role_switch_set(struct usb_role_switch *sw,
> >   	case USB_ROLE_HOST:
> >   		atomic_notifier_call_chain(&phy->notifier, USB_EVENT_ID, phy);
> >   		break;
> > +	default:
> > +		break;
> >   	}
> >   	return 0;
> > diff --git a/drivers/usb/roles/intel-xhci-usb-role-switch.c b/drivers/usb/roles/intel-xhci-usb-role-switch.c
> > index 5c96e92..4d6a3dd 100644
> > --- a/drivers/usb/roles/intel-xhci-usb-role-switch.c
> > +++ b/drivers/usb/roles/intel-xhci-usb-role-switch.c
> > @@ -97,6 +97,8 @@ static int intel_xhci_usb_set_role(struct usb_role_switch *sw,
> >   		val |= SW_VBUS_VALID;
> >   		drd_config = DRD_CONFIG_STATIC_DEVICE;
> >   		break;
> > +	default:
> > +		break;
> >   	}
> >   	val |= SW_IDPIN_EN;
> >   	if (data->enable_sw_switch) {
> > diff --git a/include/linux/usb/role.h b/include/linux/usb/role.h
> > index b5deafd..65e790a 100644
> > --- a/include/linux/usb/role.h
> > +++ b/include/linux/usb/role.h
> > @@ -11,6 +11,7 @@ enum usb_role {
> >   	USB_ROLE_NONE,
> >   	USB_ROLE_HOST,
> >   	USB_ROLE_DEVICE,
> > +	USB_ROLE_UNKNOWN,
> >   };
> >   typedef int (*usb_role_switch_set_t)(struct usb_role_switch *sw,
> 
> Hi Greg, I have fixed the drivers that doesn't have default case while using
> usb_role enum. Added the same on intel-xhci-usb-role-switch.c &
> musb/jz4740.c files. I was able to compile successfully. Please check once
> if this fixed the build issue.

Looks good, thanks!

greg k-h