linux-kernel - [PATCH v2 11/11] thermal/drivers/generic-adc: remove redundant msg in gadc_thermal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 13 Jun 2023 19:24:44 +0800
From:   Yangtao Li <frank.li@...o.com>
To:     glaroque@...libre.com, rafael@...nel.org,
        daniel.lezcano@...aro.org, amitk@...nel.org, rui.zhang@...el.com,
        shawnguo@...nel.org, s.hauer@...gutronix.de, kernel@...gutronix.de,
        festevam@...il.com, linux-imx@....com, agross@...nel.org,
        andersson@...nel.org, konrad.dybcio@...aro.org,
        thara.gopinath@...il.com, anarsoul@...il.com,
        tiny.windzz@...il.com, wens@...e.org, jernej.skrabec@...il.com,
        samuel@...lland.org, thierry.reding@...il.com,
        jonathanh@...dia.com, edubezval@...il.com, j-keerthy@...com,
        f.fainelli@...il.com
Cc:     linux-pm@...r.kernel.org, linux-amlogic@...ts.infradead.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-arm-msm@...r.kernel.org, linux-sunxi@...ts.linux.dev,
        linux-tegra@...r.kernel.org, linux-omap@...r.kernel.org,
        Yangtao Li <frank.li@...o.com>
Subject: [PATCH v2 11/11] thermal/drivers/generic-adc: remove redundant msg in gadc_thermal_probe()

The upper-layer devm_thermal_add_hwmon_sysfs() function can directly
print error information.

Signed-off-by: Yangtao Li <frank.li@...o.com>
---
 drivers/thermal/thermal-generic-adc.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/thermal/thermal-generic-adc.c b/drivers/thermal/thermal-generic-adc.c
index e7a82d5cabdb..f4f1a04f8c0f 100644
--- a/drivers/thermal/thermal-generic-adc.c
+++ b/drivers/thermal/thermal-generic-adc.c
@@ -155,11 +155,7 @@ static int gadc_thermal_probe(struct platform_device *pdev)
 		return ret;
 	}
 
-	ret = devm_thermal_add_hwmon_sysfs(&pdev->dev, gti->tz_dev);
-	if (ret) {
-		dev_warn(&pdev->dev, "Failed to add hwmon sysfs attributes\n");
-		return ret;
-	}
+	devm_thermal_add_hwmon_sysfs(&pdev->dev, gti->tz_dev);
 
 	return 0;
 }
-- 
2.39.0