[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230613134336.GA1780229-robh@kernel.org>
Date: Tue, 13 Jun 2023 07:43:36 -0600
From: Rob Herring <robh@...nel.org>
To: Piyush Mehta <piyush.mehta@....com>
Cc: michal.simek@...inx.com, git@....com, nava.manne@...inx.com,
linux-kernel@...r.kernel.org, krzysztof.kozlowski+dt@...aro.org,
linux-usb@...r.kernel.org, michal.simek@....com,
conor+dt@...nel.org, p.zabel@...gutronix.de,
devicetree@...r.kernel.org, siva.durga.prasad.paladugu@....com
Subject: Re: [PATCH V3] dt-bindings: reset: convert the xlnx,zynqmp-reset.txt
to yaml
On Tue, Jun 13, 2023 at 07:19:34AM -0600, Rob Herring wrote:
>
> On Tue, 13 Jun 2023 18:00:48 +0530, Piyush Mehta wrote:
> > Convert the binding to DT schema format. It also updates the
> > reset-controller description.
> >
> > Signed-off-by: Piyush Mehta <piyush.mehta@....com>
> > ---
> > Changes in V2:
> > - Addressed the Krzysztof review comment:
> > - Update DT binding to fix the dt_binding_check warning.
> > - Removed 2/2 - xlnx,zynqmp-firmware.yaml binding patch: Will send after
> > xlnx,zynqmp-reset.yaml binding merge.
> >
> > Link: https://lore.kernel.org/lkml/168612336438.2153757.6000360498539992409.robh@kernel.org/T/#m4abfe6287177d5fd09f781d298dd19d56aae5e27
> >
> > Changes in V3:
> > - Addressed the Krzysztof review comment:
> > - Removed 2/2 - xlnx,zynqmp-firmware.yaml binding patch: Will send after
> > xlnx,zynqmp-reset.yaml binding merge.
> > - Update title: Removed "binding".
> > - Update Example:
> > - Removed header file.
> > - Dropped three levels of indentations: firmware and zynqmp_firmware.
> > - Removed the sata example.
> >
> > Link: https://lore.kernel.org/all/22e3c25e-487b-c02f-46f3-6d2ab2be8813@linaro.org/
> > ---
> > .../bindings/reset/xlnx,zynqmp-reset.txt | 55 -------------------
> > .../bindings/reset/xlnx,zynqmp-reset.yaml | 52 ++++++++++++++++++
> > 2 files changed, 52 insertions(+), 55 deletions(-)
> > delete mode 100644 Documentation/devicetree/bindings/reset/xlnx,zynqmp-reset.txt
> > create mode 100644 Documentation/devicetree/bindings/reset/xlnx,zynqmp-reset.yaml
> >
>
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.yaml: $defs:qcom-pmic-mpp-state:properties:qcom,paired: [{'description': 'Indicates that the pin should be operating in paired mode.'}] is not of type 'object', 'boolean'
> from schema $id: http://devicetree.org/meta-schemas/core.yaml#
Unrelated. This can be ignored.
Rob
Powered by blists - more mailing lists