linux-kernel - Re: [PATCH v5] scsi: ufs: wb: Add explicit flush

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <488689a7-e68e-bd68-2cb2-f2f67baa176d@acm.org>
Date:   Tue, 13 Jun 2023 07:03:51 -0700
From:   Bart Van Assche <bvanassche@....org>
To:     Lu Hongfei <luhongfei@...o.com>,
        Alim Akhtar <alim.akhtar@...sung.com>,
        Avri Altman <avri.altman@....com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        Jinyoung Choi <j-young.choi@...sung.com>,
        Daniil Lunev <dlunev@...omium.org>,
        Bean Huo <beanhuo@...ron.com>,
        Peter Wang <peter.wang@...iatek.com>,
        open list <linux-kernel@...r.kernel.org>,
        "open list:UNIVERSAL FLASH STORAGE HOST CONTROLLER DRIVER" 
        <linux-scsi@...r.kernel.org>
Cc:     opensource.kernel@...o.com
Subject: Re: [PATCH v5] scsi: ufs: wb: Add explicit flush_threshold sysfs
 attribute

On 6/12/23 19:22, Lu Hongfei wrote:
> +	/* The range of values for wb_flush_threshold is (0,10] */
> +	if (wb_flush_threshold > UFS_WB_BUF_REMAIN_PERCENT(100) ||
> +		wb_flush_threshold == 0) {

For future patches, please align split lines as is done elsewhere in the 
kernel. This means aligning "wb_flush_threshold == 0" with 
"wb_flush_threshold > ...". Anyway:

Reviewed-by: Bart Van Assche <bvanassche@....org>