linux-kernel - Re: [PATCH] perf subcmd: Fix missing check for return value of malloc() in add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAP-5=fWQq9MM-NXL75_a_JoTVEwvS1oy8oKRefsLxU1kyjWKZg@mail.gmail.com>
Date:   Wed, 14 Jun 2023 09:21:29 -0700
From:   Ian Rogers <irogers@...gle.com>
To:     Chenyuan Mi <cymi20@...an.edu.cn>
Cc:     acme@...hat.com, namhyung@...nel.org, leo.yan@...aro.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf subcmd: Fix missing check for return value of
 malloc() in add_cmdname()

On Wed, Jun 14, 2023 at 8:01 AM Chenyuan Mi <cymi20@...an.edu.cn> wrote:
>
> The malloc() function may return NULL when it fails,
> which may cause null pointer deference in add_cmdname(),
> add Null check for return value of malloc().
>
> Found by our static analysis tool.
>
> Signed-off-by: Chenyuan Mi <cymi20@...an.edu.cn>

Acked-by: Ian Rogers <irogers@...gle.com>

Thanks,
Ian

> ---
>  tools/lib/subcmd/help.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/tools/lib/subcmd/help.c b/tools/lib/subcmd/help.c
> index bf02d62a3b2b..510a3eccb60f 100644
> --- a/tools/lib/subcmd/help.c
> +++ b/tools/lib/subcmd/help.c
> @@ -16,6 +16,8 @@
>  void add_cmdname(struct cmdnames *cmds, const char *name, size_t len)
>  {
>         struct cmdname *ent = malloc(sizeof(*ent) + len + 1);
> +       if (!ent)
> +               return;
>
>         ent->len = len;
>         memcpy(ent->name, name, len);
> --
> 2.17.1
>