linux-kernel - Re: [PATCH v5 01/22] dt-bindings: interconnect: Add Qcom RPM ICC bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c1c84eef-ee43-fcb9-de93-ba609b842d87@linaro.org>
Date:   Wed, 14 Jun 2023 18:48:14 +0200
From:   Konrad Dybcio <konrad.dybcio@...aro.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>,
        Georgi Djakov <djakov@...nel.org>,
        Leo Yan <leo.yan@...aro.org>,
        Evan Green <evgreen@...omium.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>
Cc:     Marijn Suijten <marijn.suijten@...ainline.org>,
        linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-clk@...r.kernel.org, linux-pm@...r.kernel.org,
        devicetree@...r.kernel.org
Subject: Re: [PATCH v5 01/22] dt-bindings: interconnect: Add Qcom RPM ICC
 bindings

On 14.06.2023 18:47, Krzysztof Kozlowski wrote:
> On 14/06/2023 18:43, Konrad Dybcio wrote:
>> On 14.06.2023 18:43, Krzysztof Kozlowski wrote:
>>> On 14/06/2023 12:22, Konrad Dybcio wrote:
>>>> The SMD RPM interconnect driver requires different icc tags to the
>>>> RPMh driver. Add bindings to reflect that.
>>>>
>>>> Signed-off-by: Konrad Dybcio <konrad.dybcio@...aro.org>
>>>> ---
>>>>  include/dt-bindings/interconnect/qcom,rpm-icc.h | 13 +++++++++++++
>>>>  1 file changed, 13 insertions(+)
>>>>
>>>> diff --git a/include/dt-bindings/interconnect/qcom,rpm-icc.h b/include/dt-bindings/interconnect/qcom,rpm-icc.h
>>>> new file mode 100644
>>>> index 000000000000..2cd56f91e5c5
>>>> --- /dev/null
>>>> +++ b/include/dt-bindings/interconnect/qcom,rpm-icc.h
>>>> @@ -0,0 +1,13 @@
>>>> +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
>>>> +/*
>>>> + * Copyright (c) 2023, Linaro Limited
>>>> + */
>>>> +
>>>> +#ifndef __DT_BINDINGS_INTERCONNECT_QCOM_RPM_ICC_H
>>>> +#define __DT_BINDINGS_INTERCONNECT_QCOM_RPM_ICC_H
>>>> +
>>>> +#define RPM_ACTIVE_TAG		(1 << 0)
>>>> +#define RPM_SLEEP_TAG		(1 << 1)
>>>> +#define RPM_ALWAYS_TAG		(RPM_ACTIVE_TAG | RPM_SLEEP_TAG)
>>>
>>> Where are these used? I don't see any DTS in your patchset. Did you send
>>> it separately?
>> In the driver for now, e.g. patch 19. DTS can only come after the
>> driver is fixed or things will explode!
> 
> You reference it in patch 19, but I still do not see the constants being
> used.

Fragment of P19:

 	if (!tag)
-		tag = QCOM_ICC_TAG_ALWAYS;
+		tag = RPM_ALWAYS_TAG;
 

Konrad
> 
> Best regards,
> Krzysztof
>