linux-kernel - [PATCH 0/3] backlight: lm3630a: add functionality to change boost converter frequency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20230602-lm3630a_boost_frequency-v1-0-076472036d1a@mweigand.net>
Date:   Wed, 14 Jun 2023 21:08:51 +0200
From:   Maximilian Weigand <mweigand2017@...il.com>
To:     Lee Jones <lee@...nel.org>,
        Daniel Thompson <daniel.thompson@...aro.org>,
        Jingoo Han <jingoohan1@...il.com>,
        Helge Deller <deller@....de>, Pavel Machek <pavel@....cz>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Heiko Stuebner <heiko@...ech.de>
Cc:     dri-devel@...ts.freedesktop.org, linux-fbdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-leds@...r.kernel.org,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-rockchip@...ts.infradead.org,
        Maximilian Weigand <mweigand@...igand.net>
Subject: [PATCH 0/3] backlight: lm3630a: add functionality to change boost
 converter frequency

For certain brightness settings the Pine64 PineNote exhibits quite
visible flickering of the led backlights, leading to an unpleasant user
experience. It is understood that flickering is caused by certain power
line ripples interacting with the led driver, inherent to the
specific hardware. The lm3630a led driver is able to change the boost
converter switching frequency. Among other things, changing the boost
frequency can also greatly improve visible flickering issues.

This patchset enables dts control of two frequency modifications that the
hardware is capable of: Switch from a base frequency of 500 kHz to 1
MHz, and activate a frequency shift to 560 kHz or 1.12 MHz,
respectively.

As flickering characteristics are mainly hardware dependent, this should
warrant the inclusion of two dts entries for the lm3630a led driver to
control the boost frequency of the chip on a per-device basis.

Changes were tested on a Pine64 PineNote. The following brightness
settings were found to exhibit serious flickering without either the
frequency shift or the higher boost frequency:

echo 186 > /sys/class/backlight/backlight_warm/brightness
echo 255 > /sys/class/backlight/backlight_cool/brightness

Signed-off-by: Maximilian Weigand <mweigand@...igand.net>
---
Maximilian Weigand (3):
      backlight: lm3630a: add support for changing the boost frequency
      dt-bindings: backlight: lm3630a: add entries to control boost frequency
      arm64: dts: rockchip: shift boost frequency for rk3566-pinenote backlight

 .../bindings/leds/backlight/lm3630a-backlight.yaml           | 12 ++++++++++++
 arch/arm64/boot/dts/rockchip/rk3566-pinenote.dtsi            |  1 +
 drivers/video/backlight/lm3630a_bl.c                         |  9 ++++++++-
 include/linux/platform_data/lm3630a_bl.h                     |  5 +++++
 4 files changed, 26 insertions(+), 1 deletion(-)
---
base-commit: 858fd168a95c5b9669aac8db6c14a9aeab446375
change-id: 20230602-lm3630a_boost_frequency-bae9656ec759

Best regards,
-- 
Maximilian Weigand <mweigand@...igand.net>