[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230614191808.GA2581397-robh@kernel.org>
Date: Wed, 14 Jun 2023 13:18:08 -0600
From: Rob Herring <robh@...nel.org>
To: Oleksij Rempel <o.rempel@...gutronix.de>
Cc: Abel Vesa <abelvesa@...nel.org>,
Michael Turquette <mturquette@...libre.com>,
Stephen Boyd <sboyd@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>,
Shawn Guo <shawnguo@...nel.org>,
Sascha Hauer <s.hauer@...gutronix.de>,
Herbert Xu <herbert@...dor.apana.org.au>,
"David S. Miller" <davem@...emloft.net>,
Dmitry Torokhov <dmitry.torokhov@...il.com>,
Ulf Hansson <ulf.hansson@...aro.org>, kernel@...gutronix.de,
Peng Fan <peng.fan@....com>,
Fabio Estevam <festevam@...il.com>,
NXP Linux Team <linux-imx@....com>,
Daniel Lezcano <daniel.lezcano@...aro.org>,
Thomas Gleixner <tglx@...utronix.de>,
Michael Trimarchi <michael@...rulasolutions.com>,
Mark Brown <broonie@...nel.org>,
Dario Binacchi <dario.binacchi@...rulasolutions.com>,
Anson Huang <Anson.Huang@....com>, Marek Vasut <marex@...x.de>,
linux-clk@...r.kernel.org, devicetree@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
linux-crypto@...r.kernel.org, linux-input@...r.kernel.org,
linux-mmc@...r.kernel.org
Subject: Re: [PATCH v1 6/7] dt-bindings: clock: imx6q: Allow single optional
clock and add enet_ref_pad
On Thu, Jun 01, 2023 at 12:14:50PM +0200, Oleksij Rempel wrote:
> All clocks for this driver are optional, so this change allows the
It's not about what the driver supports, but the h/w. You are saying
this SoC can operate with only 1 of any of the clock inputs?
> 'clocks' and 'clock-names' properties to accept a single clock.
> Additionally, 'enet_ref_pad' clock is added. This resolves the following
> dtbs_check warning:
> imx6dl-alti6p.dtb: clock-controller@...4000: clocks: [[24]] is too short
> From schema: Documentation/devicetree/bindings/clock/imx6q-clock.yaml
>
> imx6dl-alti6p.dtb: clock-controller@...4000: clock-names:0: 'osc' was
> expected
> From schema: Documentation/devicetree/bindings/clock/imx6q-clock.yaml
>
> imx6dl-alti6p.dtb: clock-controller@...4000: clock-names:
> ['enet_ref_pad'] is too short
> From schema: Documentation/devicetree/bindings/clock/imx6q-clock.yaml
>
> Signed-off-by: Oleksij Rempel <o.rempel@...gutronix.de>
> ---
> .../devicetree/bindings/clock/imx6q-clock.yaml | 15 +++++++++------
> 1 file changed, 9 insertions(+), 6 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/clock/imx6q-clock.yaml b/Documentation/devicetree/bindings/clock/imx6q-clock.yaml
> index bae4fcb3aacc..ed65d19c2e0e 100644
> --- a/Documentation/devicetree/bindings/clock/imx6q-clock.yaml
> +++ b/Documentation/devicetree/bindings/clock/imx6q-clock.yaml
> @@ -28,20 +28,23 @@ properties:
> const: 1
>
> clocks:
> + minItems: 1
> items:
> - description: 24m osc
> - description: 32k osc
> - description: ckih1 clock input
> - description: anaclk1 clock input
> - description: anaclk2 clock input
> + - description: enet_ref_pad
>
> clock-names:
> - items:
> - - const: osc
> - - const: ckil
> - - const: ckih1
> - - const: anaclk1
> - - const: anaclk2
> + enum:
> + - osc
> + - ckil
> + - ckih1
> + - anaclk1
> + - anaclk2
> + - enet_ref_pad
>
> fsl,pmic-stby-poweroff:
> $ref: /schemas/types.yaml#/definitions/flag
> --
> 2.39.2
>
Powered by blists - more mailing lists