[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20230614225759.GA3003701-robh@kernel.org>
Date: Wed, 14 Jun 2023 16:57:59 -0600
From: Rob Herring <robh@...nel.org>
To: Zev Weiss <zev@...ilderbeest.net>
Cc: Conor Dooley <conor+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
devicetree@...r.kernel.org, Guenter Roeck <linux@...ck-us.net>,
Jean Delvare <jdelvare@...e.com>, linux-hwmon@...r.kernel.org,
linux-kernel@...r.kernel.org, openbmc@...ts.ozlabs.org
Subject: Re: [PATCH 1/2] dt-bindings: hwmon: Add Nuvoton NCT7362Y binding
On Wed, Jun 07, 2023 at 03:18:29AM -0700, Zev Weiss wrote:
> This binding describes the NCT7362Y, a 16-channel fan/GPIO controller.
>
> Signed-off-by: Zev Weiss <zev@...ilderbeest.net>
> ---
> .../bindings/hwmon/nuvoton,nct7362.yaml | 123 ++++++++++++++++++
> 1 file changed, 123 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/hwmon/nuvoton,nct7362.yaml
>
> diff --git a/Documentation/devicetree/bindings/hwmon/nuvoton,nct7362.yaml b/Documentation/devicetree/bindings/hwmon/nuvoton,nct7362.yaml
> new file mode 100644
> index 000000000000..630dcce7a14c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/nuvoton,nct7362.yaml
> @@ -0,0 +1,123 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/hwmon/nuvoton,nct7362.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Nuvoton NCT7362Y fan controller
> +
> +maintainers:
> + - Zev Weiss <zev@...ilderbeest.net>
> +
> +description: |
> + The Nuvoton NCT7362Y is an I2C fan controller with 16 pins that can
> + be independently configured for PWM, fan tach, or GPIO
> + functionality. Each pin's functionality is represented by a child
> + node.
> +
> + The datasheet is not publicly available but can be requested from
> + Nuvoton via their web site.
> +
> +properties:
> + compatible:
> + enum:
> + - nuvoton,nct7362
> +
> + reg:
> + maxItems: 1
> +
> + "#address-cells":
> + const: 1
> +
> + "#size-cells":
> + const: 0
> +
> + gpio-controller: true
> +
> + "#gpio-cells":
> + const: 2
> +
> + gpio-line-names:
> + minItems: 1
> + maxItems: 16
> +
> +patternProperties:
> + "^tach@([1-8]|1[0-7])$":
Unit-addresses are hex typically.
Why do you need a child node for tach. Is that a separate h/w block.
> + type: object
> + properties:
> + reg:
> + maxItems: 1
> + description: The pin number.
> +
> + nuvoton,pulses-per-revolution:
This is a property of the fan attached and belongs in a fan node
describing the fan(s) properties. Until a common binding exists, further
fan controller bindings are going to be rejected.
The furthest attempt was here[1]. And there's the Aspeed effort[2] which
keeps ignoring our feedback. Please work together on these.
Rob
[1] https://lore.kernel.org/all/20221121122932.2493174-2-Naresh.Solanki@9elements.com/
[2] https://lore.kernel.org/all/20230608021839.12769-1-billy_tsai@aspeedtech.com/
Powered by blists - more mailing lists