linux-kernel - Re: [PATCH] serial: 8250_omap: Use force_suspend and resume for system suspend

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <13562904-2f92-8a2f-0dcc-71fc0687d7da@ti.com>
Date:   Wed, 14 Jun 2023 10:44:22 +0530
From:   Dhruva Gole <d-gole@...com>
To:     Tony Lindgren <tony@...mide.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jirislaby@...nel.org>, Vignesh R <vigneshr@...com>
CC:     Andy Shevchenko <andriy.shevchenko@...el.com>,
        Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
        John Ogness <john.ogness@...utronix.de>,
        Johan Hovold <johan@...nel.org>,
        Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
        <linux-omap@...r.kernel.org>, <linux-serial@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] serial: 8250_omap: Use force_suspend and resume for
 system suspend

Hi Tony,

Thanks for the fix!

On 14/06/23 10:29, Tony Lindgren wrote:
> We should not rely on autosuspend timeout for system suspend. Instead,
> let's use force_suspend and force_resume functions. Otherwise the serial
> port controller device may not be idled on suspend.
> 
> As we are doing a register write on suspend to configure the serial port,
> we still need to runtime PM resume the port on suspend.
> 
> While at it, let's switch to pm_runtime_resume_and_get() and check for
> errors returned. And let's add the missing line break before return to the
> suspend function while at it.
> 
> Fixes: 09d8b2bdbc5c ("serial: 8250: omap: Provide ability to enable/disable UART as wakeup source")
> Signed-off-by: Tony Lindgren <tony@...mide.com>
> ---

Tested-by: Dhruva Gole <d-gole@...com>

>   drivers/tty/serial/8250/8250_omap.c | 20 +++++++++++++++-----
>   1 file changed, 15 insertions(+), 5 deletions(-)
> [...]


-- 
Thanks and Regards,
Dhruva Gole