linux-kernel - Re: [PATCH] drm/fbdev-generic: Remove a redundant assignment clause

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b99747c5-8810-d2b6-80c7-dbc85fcefb8b@suse.de>
Date:   Wed, 14 Jun 2023 07:29:20 +0200
From:   Thomas Zimmermann <tzimmermann@...e.de>
To:     Sui Jingfeng <suijingfeng@...ngson.cn>,
        Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
        Maxime Ripard <mripard@...nel.org>,
        David Airlie <airlied@...il.com>,
        Daniel Vetter <daniel@...ll.ch>
Cc:     dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/fbdev-generic: Remove a redundant assignment clause

Hi

Am 14.06.23 um 03:30 schrieb Sui Jingfeng:
> The assignment "dst = map;" in the drm_fbdev_generic_damage_blit() function
> is redundant because it has already been copied when the call to
> drm_client_buffer_vmap() is finished. Therefore, this patch saves a useless
> copy. No functional change.

Isn't that what we discussed here?

https://lore.kernel.org/dri-devel/20230325074636.136833-1-15330273260@189.cn/

Best regards
Thomas

> 
> Signed-off-by: Sui Jingfeng <suijingfeng@...ngson.cn>
> ---
>   drivers/gpu/drm/drm_fbdev_generic.c | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/drm_fbdev_generic.c b/drivers/gpu/drm/drm_fbdev_generic.c
> index 98ae703848a0..aa6924e3a58c 100644
> --- a/drivers/gpu/drm/drm_fbdev_generic.c
> +++ b/drivers/gpu/drm/drm_fbdev_generic.c
> @@ -182,7 +182,7 @@ static int drm_fbdev_generic_damage_blit(struct drm_fb_helper *fb_helper,
>   					 struct drm_clip_rect *clip)
>   {
>   	struct drm_client_buffer *buffer = fb_helper->buffer;
> -	struct iosys_map map, dst;
> +	struct iosys_map map;
>   	int ret;
>   
>   	/*
> @@ -202,8 +202,7 @@ static int drm_fbdev_generic_damage_blit(struct drm_fb_helper *fb_helper,
>   	if (ret)
>   		goto out;
>   
> -	dst = map;
> -	drm_fbdev_generic_damage_blit_real(fb_helper, clip, &dst);
> +	drm_fbdev_generic_damage_blit_real(fb_helper, clip, &map);
>   
>   	drm_client_buffer_vunmap(buffer);
>   

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)

Download attachment "OpenPGP_signature" of type "application/pgp-signature" (841 bytes)