linux-kernel - Re: [PATCH v4 4/4] MAINTAINERS: add Cadence USBHS driver entry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 14 Jun 2023 08:18:34 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Pawel Laszczak <pawell@...ence.com>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "Daisy.Barrera@...iusxm.com" <Daisy.Barrera@...iusxm.com>,
        "Cliff.Holden@...iusxm.com" <Cliff.Holden@...iusxm.com>,
        "tony@...mide.com" <tony@...mide.com>,
        "jdelvare@...e.de" <jdelvare@...e.de>,
        "neal_liu@...eedtech.com" <neal_liu@...eedtech.com>,
        "linus.walleij@...aro.org" <linus.walleij@...aro.org>,
        "egtvedt@...fundet.no" <egtvedt@...fundet.no>,
        "biju.das.jz@...renesas.com" <biju.das.jz@...renesas.com>,
        "herve.codina@...tlin.com" <herve.codina@...tlin.com>
Subject: Re: [PATCH v4 4/4] MAINTAINERS: add Cadence USBHS driver entry

On Wed, Jun 14, 2023 at 05:45:46AM +0000, Pawel Laszczak wrote:
> 
> >
> >On Fri, Jun 02, 2023 at 06:26:44AM -0400, Pawel Laszczak wrote:
> >> Patch adds entry for USBHS (CDNS2) driver into MAINTARNERS file
> >>
> >> Signed-off-by: Pawel Laszczak <pawell@...ence.com>
> >> ---
> >>  MAINTAINERS | 6 ++++++
> >>  1 file changed, 6 insertions(+)
> >>
> >> diff --git a/MAINTAINERS b/MAINTAINERS index
> >> c269a15609e2..8b289d52d983 100644
> >> --- a/MAINTAINERS
> >> +++ b/MAINTAINERS
> >> @@ -4523,6 +4523,12 @@ T:	git
> >git://git.kernel.org/pub/scm/linux/kernel/git/peter.chen/usb.git
> >>  F:	drivers/usb/cdns3/
> >>  X:	drivers/usb/cdns3/cdns3*
> >>
> >> +CADENCE USBHS DRIVER
> >> +M:	Pawel Laszczak <pawell@...ence.com>
> >> +L:	linux-usb@...r.kernel.org
> >> +S:	Maintained
> >
> >This isn't part of your job description?  Why doesn't Cadence allow you to do
> >that?  That's not good on a bunch of levels, have you seen the
> >Documentation/process/contribution-maturity-model.rst file yet?
> >
> 
> I have read it now, but I don't understand where I made mistake.
> I guess that I should not be added as maintainer. Am I right?
> 
> I responsible for:
> 1. developing USBHS driver
> 2. upstreaming USBH driver
> 3. fixing issue detected by me or by our customers.

It's the "S: Maintained" line I am curious about.  "Maintained" means
"Someone actually looks after it.", while if you put "Supported" that
means "Someone is actually paid to look after this."

The difference is the first is usually on your own time as a best-effort
on your part, the second is that it is part of your job from your
employer.

If Cadence doesn't allow you to do maintaince work on company time, then
the entry is correct as you wrote it.  Otherwise you might want to
change that.  See the top of the MAINTAINERS file for the other options
you have here for this field if neither of these are correct.

thanks,

greg k-h