linux-kernel - [PATCH] perf tools:remove unneeded variable from perf_event_attr_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <329a5b1b6e2c9061467ed6ef82247b8d@208suo.com>
Date:   Wed, 14 Jun 2023 14:25:32 +0800
From:   baomingtong001@...suo.com
To:     peterz@...radead.org, mingo@...hat.com, acme@...nel.org,
        mark.rutland@....com, alexander.shishkin@...ux.intel.com,
        jolsa@...nel.org, namhyung@...nel.org, irogers@...gle.com,
        adrian.hunter@...el.com, anshuman.khandual@....com
Cc:     linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH] perf tools:remove unneeded variable from
 perf_event_attr__fprintf()

fix the following coccicheck warning:

tools/perf/util/perf_event_attr_fprintf.c:97:5-8: Unneeded variable: 
"ret". Return "0".

Signed-off-by: Mingtong Bao <baomingtong001@...suo.com>
---
  tools/perf/util/perf_event_attr_fprintf.c | 3 +--
  1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/tools/perf/util/perf_event_attr_fprintf.c 
b/tools/perf/util/perf_event_attr_fprintf.c
index 7e5e7b30510d..4a8f625b80c7 100644
--- a/tools/perf/util/perf_event_attr_fprintf.c
+++ b/tools/perf/util/perf_event_attr_fprintf.c
@@ -94,7 +94,6 @@ int perf_event_attr__fprintf(FILE *fp, struct 
perf_event_attr *attr,
                   attr__fprintf_f attr__fprintf, void *priv)
  {
      char buf[BUF_SIZE];
-    int ret = 0;

      PRINT_ATTRf(type, p_unsigned);
      PRINT_ATTRf(size, p_unsigned);
@@ -155,5 +154,5 @@ int perf_event_attr__fprintf(FILE *fp, struct 
perf_event_attr *attr,
      PRINT_ATTRf(aux_sample_size, p_unsigned);
      PRINT_ATTRf(sig_data, p_unsigned);

-    return ret;
+    return 0;
  }