linux-kernel - [PATCH] wifi: rtw89: Remove unneeded variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <bef94b1701cd3a9718dff8aff1f4e7f4@208suo.com>
Date:   Wed, 14 Jun 2023 14:28:27 +0800
From:   xuanzhenggang001@...suo.com
To:     pkshih@...ltek.com, kvalo@...nel.org
Cc:     linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH] wifi: rtw89: Remove unneeded variable

Fix the following coccicheck warning:

drivers/net/wireless/realtek/rtw89/pci.c:239:5-8: Unneeded variable: 
"cnt".

Signed-off-by: Zhenggang Xuan <xuanzhenggang001@...suo.com>
---
  drivers/net/wireless/realtek/rtw89/pci.c | 5 ++---
  1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/net/wireless/realtek/rtw89/pci.c 
b/drivers/net/wireless/realtek/rtw89/pci.c
index 9402f1a0caea..591b7b9a6eca 100644
--- a/drivers/net/wireless/realtek/rtw89/pci.c
+++ b/drivers/net/wireless/realtek/rtw89/pci.c
@@ -236,7 +236,6 @@ static u32 rtw89_pci_rxbd_deliver_skbs(struct 
rtw89_dev *rtwdev,
      struct sk_buff *skb;
      u32 rxinfo_size = sizeof(struct rtw89_pci_rxbd_info);
      u32 offset;
-    u32 cnt = 1;
      bool fs, ls;
      int ret;

@@ -297,7 +296,7 @@ static u32 rtw89_pci_rxbd_deliver_skbs(struct 
rtw89_dev *rtwdev,
          desc_info->ready = false;
      }

-    return cnt;
+    return 1;

  err_sync_device:
      rtw89_pci_sync_skb_for_device(rtwdev, skb);
@@ -308,7 +307,7 @@ static u32 rtw89_pci_rxbd_deliver_skbs(struct 
rtw89_dev *rtwdev,
      rx_ring->diliver_skb = NULL;
      desc_info->ready = false;

-    return cnt;
+    return 1;
  }

  static void rtw89_pci_rxbd_deliver(struct rtw89_dev *rtwdev,