linux-kernel - Re: [PATCH v1] iio: ado: ad7192: Add error check and more debug log

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230614081510.63602edd@jic23-huawei>
Date:   Wed, 14 Jun 2023 08:15:10 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Nuno Sá <noname.nuno@...il.com>
Cc:     Markus Burri <markus.burri@...com>, linux-kernel@...r.kernel.org,
        Alexandru Tachici <alexandru.tachici@...log.com>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Michael Hennerich <Michael.Hennerich@...log.com>,
        linux-iio@...r.kernel.org
Subject: Re: [PATCH v1] iio: ado: ad7192: Add error check and more debug log

On Tue, 13 Jun 2023 10:46:30 +0200
Nuno Sá <noname.nuno@...il.com> wrote:

> On Tue, 2023-06-13 at 10:19 +0200, Nuno Sá wrote:
> > On Tue, 2023-06-13 at 07:42 +0200, Markus Burri wrote:  
> > > Print read and expected device ID as debug warning.
> > > Add error check for ad_sd_init() result.
> > > 
> > > Signed-off-by: Markus Burri <markus.burri@...com>
> > > ---  
> > 
> > You have unrelated changes but they are easy enough to go in same patch
> > (at least for me). Hence:
> >   
> 
> Actually, consider my tag valid after fixing the typo you have in the commit
> message...
> 
This is also v2...  So patch title should reflect that.
(well v3 for next version with the typo fixed)


> > Reviewed-by: Nuno Sa <nuno.sa@...log.com>
> > 
> >   
>