linux-kernel - Re: [PATCH] wifi: ath9k: remove unneeded variable from ath9k_dump_legacy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <02650a6d4c82bce62a9625714540ea75f7b3f571.camel@sipsolutions.net>
Date:   Wed, 14 Jun 2023 09:38:15 +0200
From:   Johannes Berg <johannes@...solutions.net>
To:     baomingtong001@...suo.com, kvalo@...nel.org
Cc:     linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] wifi: ath9k: remove unneeded variable from
 ath9k_dump_legacy_btcoex()

On Wed, 2023-06-14 at 14:13 +0800, baomingtong001@...suo.com wrote:
> Fix the following coccicheck warning:
> 
> drivers/net/wireless/ath/ath9k/gpio.c:501:5-8: Unneeded variable: "len".
> 
> Signed-off-by: Mingtong Bao <baomingtong001@...suo.com>

Same here. I'm even wondering if there are different people behind this?

Also, I'm wondering what you're up to - are you all training or
something? I see the same kind of patches that are the same kind of
broken from a handful of different people?

> ---
>   drivers/net/wireless/ath/ath9k/gpio.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/net/wireless/ath/ath9k/gpio.c 
> b/drivers/net/wireless/ath/ath9k/gpio.c
> index b457e52dd365..f3d1bc02e633 100644
> --- a/drivers/net/wireless/ath/ath9k/gpio.c
> +++ b/drivers/net/wireless/ath/ath9k/gpio.c
> @@ -498,14 +498,13 @@ static int ath9k_dump_legacy_btcoex(struct 
> ath_softc *sc, u8 *buf, u32 size)
>   {
> 
>       struct ath_btcoex *btcoex = &sc->btcoex;
> -    u32 len = 0;
> 
>       ATH_DUMP_BTCOEX("Stomp Type", btcoex->bt_stomp_type);
>       ATH_DUMP_BTCOEX("BTCoex Period (msec)", btcoex->btcoex_period);
>       ATH_DUMP_BTCOEX("Duty Cycle", btcoex->duty_cycle);
>       ATH_DUMP_BTCOEX("BT Wait time", btcoex->bt_wait_time);
> 
> -    return len;
> +    return 0;
> 

This won't even build.

Please try to understand the code you're modifying before you do. And
no, build-testing it (and fixing it) will not result anything better.

johannes