linux-kernel - Re: [PATCH] b43legacy: Remove unneeded variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <058dd31ef48495f8641f5b66839aaea039af0f08.camel@sipsolutions.net>
Date:   Wed, 14 Jun 2023 10:16:57 +0200
From:   Johannes Berg <johannes@...solutions.net>
To:     wuyonggang001@...suo.com, Larry.Finger@...inger.net,
        kvalo@...nel.org
Cc:     linux-wireless@...r.kernel.org, b43-dev@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] b43legacy: Remove unneeded variable

On Wed, 2023-06-14 at 10:02 +0200, Johannes Berg wrote:
> On Wed, 2023-06-14 at 15:55 +0800, wuyonggang001@...suo.com wrote:
> > Fix the following coccicheck warning:
> > 
> > drivers/net/wireless/broadcom/b43legacy/debugfs.c:68:9-14: Unneeded 
> > variable: "count".
> 
> Hey, no. Please stop it already. This won't even _compile_. Just don't.
> There's really not much value in cleaning up those coccicheck warnings
> in the first place. You're just wasting everyone's time (including your
> own).

And BTW, I've just looked at all your other contributions to other areas
of the kernel, and heard from others as well - not doing any better!

I can only suggest that you stop all of your patch submissions and re-
evaluate what you're even trying to do. And not just you personally, but
all of the @208suo.com folks who popped up recently.

johannes