linux-kernel - Re: [PATCH] mm: page_io: Prefer 'unsigned int' to bare use of 'unsigned'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 14 Jun 2023 10:41:57 +0200
From:   David Hildenbrand <david@...hat.com>
To:     hexingwei001@...suo.com, akpm@...ux-foundation.org
Cc:     linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm: page_io: Prefer 'unsigned int' to bare use of
 'unsigned'

On 14.06.23 09:23, hexingwei001@...suo.com wrote:
> Fix the following checkpatch warning:
> 
> mm/page_io.c:87: WARNING: Prefer 'unsigned int' to bare use of
> 'unsigned'.
> mm/page_io.c:89: WARNING: Prefer 'unsigned int' to bare use of
> 'unsigned'.
> mm/page_io.c:109: WARNING: Prefer 'unsigned int' to bare use of
> 'unsigned'.
> 
> Signed-off-by: Xingwei He <hexingwei001@...suo.com>
> ---
>    mm/page_io.c | 6 +++---
>    1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/mm/page_io.c b/mm/page_io.c
> index 684cd3c7b59b..138f73386612 100644
> --- a/mm/page_io.c
> +++ b/mm/page_io.c
> @@ -84,9 +84,9 @@ int generic_swapfile_activate(struct swap_info_struct
> *sis,
>    {
>        struct address_space *mapping = swap_file->f_mapping;
>        struct inode *inode = mapping->host;
> -    unsigned blocks_per_page;
> +    unsigned int blocks_per_page;
>        unsigned long page_no;
> -    unsigned blkbits;
> +    unsigned int blkbits;
>        sector_t probe_block;
>        sector_t last_block;
>        sector_t lowest_block = -1;
> @@ -106,7 +106,7 @@ int generic_swapfile_activate(struct
> swap_info_struct *sis,
>        last_block = i_size_read(inode) >> blkbits;
>        while ((probe_block + blocks_per_page) <= last_block &&
>                page_no < sis->max) {
> -        unsigned block_in_page;
> +        unsigned int block_in_page;
>            sector_t first_block;
> 
>            cond_resched();
> 

Reviewed-by: David Hildenbrand <david@...hat.com>

-- 
Cheers,

David / dhildenb