linux-kernel - Re: [PATCH] gdb: linux: make SB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <168673252566.2889415.6583119718907787971@Monstersaurus>
Date:   Wed, 14 Jun 2023 09:48:45 +0100
From:   Kieran Bingham <kieran.bingham@...asonboard.com>
To:     Johannes Berg <johannes@...solutions.net>,
        linux-kernel@...r.kernel.org
Cc:     Jan Kiszka <jan.kiszka@...mens.com>,
        Kieran Bingham <kbingham@...nel.org>,
        Christian Brauner <brauner@...nel.org>,
        Johannes Berg <johannes.berg@...el.com>
Subject: Re: [PATCH] gdb: linux: make SB_* constants gdb-parsed

Hi Johannes,

Quoting Johannes Berg (2023-06-13 20:11:59)
> From: Johannes Berg <johannes.berg@...el.com>
> 
> These now contain "UL" suffixes due to the use of BIT(),
> so they need to be parsed by gdb since python doesn't
> understand that.
> 
Thank you for the patch, however there is an existing patch [0] submitted
and on it's way upstream [1] to resolve this.

[0] https://lore.kernel.org/all/20230607221337.2781730-1-florian.fainelli@broadcom.com/
[1] https://lore.kernel.org/all/20230609004453.2AAEEC433EF@smtp.kernel.org/

> Also fix a comment typo while at it.
> 

This typo wasn't fixed though. Perhaps that's worth a separate patch if
you wish ...

--
Regards

Kieran

> ticket=none
> 
> Fixes: f15afbd34d8f ("fs: fix undefined behavior in bit shift for SB_NOUSER")
> Signed-off-by: Johannes Berg <johannes.berg@...el.com>
> ---
>  scripts/gdb/linux/constants.py.in | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/scripts/gdb/linux/constants.py.in b/scripts/gdb/linux/constants.py.in
> index 471300ba176c..646fffddd862 100644
> --- a/scripts/gdb/linux/constants.py.in
> +++ b/scripts/gdb/linux/constants.py.in
> @@ -48,14 +48,14 @@ if IS_BUILTIN(CONFIG_COMMON_CLK):
>      LX_GDBPARSED(CLK_GET_RATE_NOCACHE)
>  
>  /* linux/fs.h */
> -LX_VALUE(SB_RDONLY)
> -LX_VALUE(SB_SYNCHRONOUS)
> -LX_VALUE(SB_MANDLOCK)
> -LX_VALUE(SB_DIRSYNC)
> -LX_VALUE(SB_NOATIME)
> -LX_VALUE(SB_NODIRATIME)
> +LX_GDBPARSED(SB_RDONLY)
> +LX_GDBPARSED(SB_SYNCHRONOUS)
> +LX_GDBPARSED(SB_MANDLOCK)
> +LX_GDBPARSED(SB_DIRSYNC)
> +LX_GDBPARSED(SB_NOATIME)
> +LX_GDBPARSED(SB_NODIRATIME)
>  
> -/* linux/htimer.h */
> +/* linux/hrtimer.h */
>  LX_GDBPARSED(hrtimer_resolution)
>  
>  /* linux/irq.h */
> -- 
> 2.40.1
>