linux-kernel - Re: [PATCH v3] pwm: mtk_disp: Fix the disable flow of disp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230614092920.sl2qjdx3wbf7xtcm@pengutronix.de>
Date:   Wed, 14 Jun 2023 11:29:20 +0200
From:   Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
To:     Shuijing Li <shuijing.li@...iatek.com>
Cc:     thierry.reding@...il.com, matthias.bgg@...il.com,
        angelogioacchino.delregno@...labora.com,
        devicetree@...r.kernel.org, linux-pwm@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org,
        Project_Global_Chrome_Upstream_Group@...iatek.com,
        jitao.shi@...iatek.com, Fei Shao <fshao@...omium.org>
Subject: Re: [PATCH v3] pwm: mtk_disp: Fix the disable flow of disp_pwm

On Wed, May 31, 2023 at 11:10:01AM +0800, Shuijing Li wrote:
> There is a flow error in the original mtk_disp_pwm_apply() function.
> If this function is called when the clock is disabled, there will be a
> chance to operate the disp_pwm register, resulting in disp_pwm exception.
> Fix this accordingly.
> 
> Fixes: 888a623db5d0 ("pwm: mtk-disp: Implement atomic API .apply()")
> Signed-off-by: Shuijing Li <shuijing.li@...iatek.com>
> Reviewed-by: Matthias Brugger <matthias.bgg@...il.com>
> Tested-by: Fei Shao <fshao@...omium.org>

When I sent my ack for v2, I missed there was already a v3, so here
again for the sake of easier maintenance:

Acked-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>

> ---
> Changes in v3:
> Add Fixes per suggestion from the previous thread:

Note that for that a new version isn't necessary, patchwork (and I think
also b4) pick up a fixes line from replies.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)