linux-kernel - Re: [PATCH] m68k/q40: Fix syntax error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMuHMdVEOxVs1YOnmhbgqWMqpG-erahs8_OdpL1Jhck7KK+F0g@mail.gmail.com>
Date:   Wed, 14 Jun 2023 11:34:36 +0200
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     wuyonggang001@...suo.com
Cc:     linux-m68k@...ts.linux-m68k.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] m68k/q40: Fix syntax error

Hi Yonggang,

Thanks for your patch!

On Wed, Jun 14, 2023 at 8:16 AM <wuyonggang001@...suo.com> wrote:
>
> Fix the following checkpatch error:

The patch subject does not match the description.

>
> ERROR: space required after that ',' (ctx:VxV)
> ERROR: spaces required around that '<' (ctx:VxV)
>
> Signed-off-by: Yonggang Wu <wuyonggang001@...suo.com>

scripts/checkpatch.pl says:

    WARNING: From:/Signed-off-by: email name mismatch: 'From:
wuyonggang001@...suo.com' != 'Signed-off-by: Yonggang Wu
<wuyonggang001@...suo.com>'

> --- a/arch/m68k/q40/config.c
> +++ b/arch/m68k/q40/config.c

> @@ -270,7 +270,7 @@ static int q40_set_rtc_pll(struct rtc_pll_info *pll)
>       if (!pll->pll_ctrl) {
>           /* the docs are a bit unclear so I am doublesetting */
>           /* RTC_WRITE here ... */
> -        int tmp = (pll->pll_value & 31) | (pll->pll_value<0 ? 32 : 0) |
> +        int tmp = (pll->pll_value & 31) | (pll->pll_value < 0 ? 32 : 0)
> |

ERROR: patch seems to be corrupt (line wrapped?)

>                 Q40_RTC_WRITE;
>           Q40_RTC_CTRL |= Q40_RTC_WRITE;
>           Q40_RTC_CTRL = tmp;


Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds