linux-kernel - Re: [PATCH] sound: usb: quirks: add flag for HEM devices to enable native DSD playback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87jzw69ssz.wl-tiwai@suse.de>
Date:   Wed, 14 Jun 2023 13:39:24 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     Lukasz Tyl <ltyl@...-e.com>
Cc:     perex@...ex.cz, tiwai@...e.com, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org, pgorgon@...-e.com
Subject: Re: [PATCH] sound: usb: quirks: add flag for HEM devices to enable native DSD playback

On Wed, 14 Jun 2023 13:33:50 +0200,
Lukasz Tyl wrote:
> 
> This commit adds new DEVICE_FLG with QUIRK_FLAG_DSD_RAW and Vendor Id for
> HEM devices which supports native DSD. Prior to this change Linux kernel
> was not enabling native DSD playback for HEM devices, and as a result,
> DSD audio was being converted to PCM "on the fly". HEM devices,
> when connected to the system, would only play audio in PCM format,
> even if the source material was in DSD format. With the addition of new
> VENDOR_FLG in the quircks.c file, the devices are now correctly
> recognized, and raw DSD data is transmitted to the device,
> allowing for native DSD playback.
> 
> Signed-off-by: Lukasz Tyl <ltyl@...-e.com>
> ---
>  sound/usb/quirks.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c
> index 3ecd1ba7fd4b..1414bf15ac21 100644
> --- a/sound/usb/quirks.c
> +++ b/sound/usb/quirks.c
> @@ -2197,6 +2197,8 @@ static const struct usb_audio_quirk_flags_table quirk_flags_table[] = {
>  		   QUIRK_FLAG_DSD_RAW),
>  	VENDOR_FLG(0xc502, /* HiBy devices */
>  		   QUIRK_FLAG_DSD_RAW),
> +	VENDOR_FLG(0x3336, /* HEM devices */
> +		   QUIRK_FLAG_DSD_RAW),

The entry is sorted in vendor id number.  Could you try to put at the
right position?


thanks,

Takashi