linux-kernel - Re: [PATCH v6 2/2] iio: adc: max14001: New driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VdQJ39Uw8bPD+y7GS7W2iJhjs2D4L-=-Fo0Jeb+8Ffn8g@mail.gmail.com>
Date:   Wed, 14 Jun 2023 14:53:12 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     "Paller, Kim Seer" <KimSeer.Paller@...log.com>
Cc:     "jic23@...nel.org" <jic23@...nel.org>,
        "lars@...afoo.de" <lars@...afoo.de>,
        "lgirdwood@...il.com" <lgirdwood@...il.com>,
        "broonie@...nel.org" <broonie@...nel.org>,
        "Hennerich, Michael" <Michael.Hennerich@...log.com>,
        "robh@...nel.org" <robh@...nel.org>,
        "krzysztof.kozlowski@...aro.org" <krzysztof.kozlowski@...aro.org>,
        "conor+dt@...nel.org" <conor+dt@...nel.org>,
        "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: Re: [PATCH v6 2/2] iio: adc: max14001: New driver

On Wed, Jun 14, 2023 at 1:43 PM Paller, Kim Seer
<KimSeer.Paller@...log.com> wrote:
> > From: Andy Shevchenko <andy.shevchenko@...il.com>
> > Sent: Wednesday, June 14, 2023 5:12 PM

...

> > > +               /* select external voltage reference source for the ADC */
> > > +               ret = max14001_reg_update(st, MAX14001_CFG,
> > > +                                         MAX14001_CFG_EXRF, 1);
> > > +
> > > +               ret = regulator_get_voltage(vref);
> > > +               if (ret < 0)
> > > +                       return dev_err_probe(dev, ret,
> > > +                                            "Failed to get vref\n");
> >
> > Is it important to choose the external reference source _before_ getting the
> > voltage of the regulator? If not, I would swap these calls, otherwise the
> > comment is needed to explain why the sequence is important in the way it's
> > written.
>
> It is not important. These calls can be swap without any issues.

If you send a new version, please swap, otherwise I hope Jonathan can
do it when applying.

-- 
With Best Regards,
Andy Shevchenko