linux-kernel - Re: [PATCH RFC] media: camss: Intepret OF graph connections more sensibly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0411f4ec-79a4-520b-e246-f20ffb0f1e8e@linaro.org>
Date:   Wed, 14 Jun 2023 14:55:01 +0100
From:   Bryan O'Donoghue <bryan.odonoghue@...aro.org>
To:     Konrad Dybcio <konrad.dybcio@...aro.org>,
        Robert Foss <rfoss@...nel.org>,
        Todor Tomov <todor.too@...il.com>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Mauro Carvalho Chehab <mchehab@...nel.org>
Cc:     Marijn Suijten <marijn.suijten@...ainline.org>,
        Yassine Oudjana <y.oudjana@...tonmail.com>,
        linux-media@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH RFC] media: camss: Intepret OF graph connections more
 sensibly

On 14/06/2023 14:50, Konrad Dybcio wrote:
> On 14.06.2023 15:48, Bryan O'Donoghue wrote:
>> On 14/06/2023 14:22, Konrad Dybcio wrote:
>>> Not all endpoints of camss have to be populated. In fact, most of the
>>> time they shouldn't be as n-th auxilliary cameras are usually ewaste.
>>>
>>> Don't fail probing the entire camss even even one endpoint is not
>>> linked and throw an error when none is found.
>>>
>>> Signed-off-by: Konrad Dybcio <konrad.dybcio@...aro.org>
>>> ---
>>>    drivers/media/platform/qcom/camss/camss.c | 7 +++----
>>>    1 file changed, 3 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/drivers/media/platform/qcom/camss/camss.c b/drivers/media/platform/qcom/camss/camss.c
>>> index 1ef26aea3eae..3aa03fbc94e2 100644
>>> --- a/drivers/media/platform/qcom/camss/camss.c
>>> +++ b/drivers/media/platform/qcom/camss/camss.c
>>> @@ -1084,9 +1084,8 @@ static int camss_of_parse_ports(struct camss *camss)
>>>              remote = of_graph_get_remote_port_parent(node);
>>>            if (!remote) {
>>> -            dev_err(dev, "Cannot get remote parent\n");
>>> -            ret = -EINVAL;
>>> -            goto err_cleanup;
>>> +            of_node_put(node);
>>> +            continue;
>>>            }
>>>              csd = v4l2_async_nf_add_fwnode(&camss->notifier,
>>> @@ -1105,7 +1104,7 @@ static int camss_of_parse_ports(struct camss *camss)
>>>            num_subdevs++;
>>>        }
>>>    -    return num_subdevs;
>>> +    return num_subdevs ? num_subdevs : -EINVAL;

Can you if/else this instead of the ?

Then add my Acked-by:

---
bod