linux-kernel - Re: [PATCH] of: unittest: drop assertions for GPIO hog messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAL_JsqLAC8oLLyNKMCOcMDjVpuMGK9E3zoYBejwuGGu4p9SDEA@mail.gmail.com>
Date:   Thu, 15 Jun 2023 08:10:24 -0600
From:   Rob Herring <robh+dt@...nel.org>
To:     Bartosz Golaszewski <brgl@...ev.pl>
Cc:     Frank Rowand <frowand.list@...il.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-gpio@...r.kernel.org,
        Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
Subject: Re: [PATCH] of: unittest: drop assertions for GPIO hog messages

On Fri, Jun 9, 2023 at 2:15 PM Bartosz Golaszewski <brgl@...ev.pl> wrote:
>
> On Fri, Jun 9, 2023 at 7:01 PM Rob Herring <robh+dt@...nel.org> wrote:
> >
> > On Fri, Jun 9, 2023 at 8:36 AM Bartosz Golaszewski <brgl@...ev.pl> wrote:
> > >
> > > From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> > >
> > > These have now been demoted to debug and are normally hidden. Drop the
> > > assertions entirely.
> > >
> > > Suggested-by: Rob Herring <robh@...nel.org>
> > > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> > > ---
> > >  drivers/of/unittest.c | 28 ----------------------------
> > >  1 file changed, 28 deletions(-)
> >
> > Why is this a separate patch? Don't I get at least 5 days to
> > review/ack changes in drivers/of/?
> >
>
> Sorry, my bad, I queued the previous one through the GPIO tree after
> it was reviewed here thinking the unittests bits are trivial. I can
> back it out if you insist or you can ack this one and the end effect
> is the same? I will pay attention in the future.

I'd prefer it to be squashed, but either way:

Acked-by: Rob Herring <robh@...nel.org>