linux-kernel - Re: [PATCH] kbuild: revive "Entering directory" for Make >= 4.4.1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK7LNAQqvLBVYwu=jo+2ngQf5PM=imHOSCi3AUdOJ-8HJG-UYQ@mail.gmail.com>
Date:   Thu, 15 Jun 2023 23:16:09 +0900
From:   Masahiro Yamada <masahiroy@...nel.org>
To:     Nicolas Schier <nicolas@...sle.eu>
Cc:     linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org,
        David Howells <dhowells@...hat.com>,
        Nathan Chancellor <nathan@...nel.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>
Subject: Re: [PATCH] kbuild: revive "Entering directory" for Make >= 4.4.1

On Thu, Jun 15, 2023 at 5:34 AM Nicolas Schier <nicolas@...sle.eu> wrote:
>
> On Sun 11 Jun 2023 01:17:11 +0900, Masahiro Yamada wrote:
> > With commit 9da0763bdd82 ("kbuild: Use relative path when building in
> > a subdir of the source tree"), compiler messages in out-of-tree builds
> > include relative paths, which are relative to the build directory, not
> > the directory where make was started.
> >
> > To help IDEs/editors find the source files, Kbuild lets GNU Make print
> > "Entering directory ..." when it changes the working directory. It has
> > been working fine for a long time, but David reported it is broken with
> > GNU Make 4.4.1.
> >
> > The behavior was changed by GNU Make commit 8f9e7722ff0f ("[SV 63537]
> > Fix setting -w in makefiles"). Previously, setting --no-print-directory
> > to MAKEFLAGS only affected child makes, but it is now interpreted in
> > the current make as soon as it is set.
> >
> > [test code]
> >
> >   $ cat /tmp/Makefile
> >   MAKEFLAGS += --no-print-directory
> >   all: ; :
> >
> > [before 8f9e7722ff0f]
> >
> >   $ make -C /tmp
> >   make: Entering directory '/tmp'
> >   :
> >   make: Leaving directory '/tmp'
> >
> > [after 8f9e7722ff0f]
> >
> >   $ make -C /tmp
> >   :
> >
> > This commit restores the previous behavior for GNU Make >= 4.4.1.
> >
> > Reported-by: David Howells <dhowells@...hat.com>
> > Closes: https://lore.kernel.org/all/2427604.1686237298@warthog.procyon.org.uk/
> > Signed-off-by: Masahiro Yamada <masahiroy@...nel.org>
> > ---


Sorry, I retract this patch.
It does not work.

-- 
Best Regards
Masahiro Yamada