linux-kernel - Re: [PATCH v6 1/5] kernel/reboot: emergency_restart: set correct system

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230615143909.fjr25wghwrtepk6g@unwieldy>
Date:   Thu, 15 Jun 2023 09:39:09 -0500
From:   Nishanth Menon <nm@...com>
To:     Francesco Dolcini <francesco@...cini.it>
CC:     Benjamin Bara <bbara93@...il.com>, Wolfram Sang <wsa@...nel.org>,
        Lee Jones <lee@...nel.org>, <rafael.j.wysocki@...el.com>,
        <dmitry.osipenko@...labora.com>, <peterz@...radead.org>,
        <jonathanh@...dia.com>, <richard.leitner@...ux.dev>,
        <treding@...dia.com>, <linux-kernel@...r.kernel.org>,
        <linux-i2c@...r.kernel.org>, <linux-tegra@...r.kernel.org>,
        Benjamin Bara <benjamin.bara@...data.com>,
        <stable@...r.kernel.org>
Subject: Re: [PATCH v6 1/5] kernel/reboot: emergency_restart: set correct
 system_state

On 15:21-20230615, Francesco Dolcini wrote:
> > > 
> > > -- 
> > > 2.34.1
> > > 
> > 
> > Tested-by: Nishanth Menon <nm@...com>
> > 
> > This in addition to a deeper bug in our driver seems to have helped
> > resolve a report we had been looking at. Tested on beagleplay platform
> > 
> > https://lore.kernel.org/all/ZGeHMjlnob2GFyHF@francesco-nb.int.toradex.com/
> 
> Is this patch going to fix the RCU warning I reported on that email or
> it is just part of a more complex solution?

>From what I see, It is part of the solution.
Problem happens as follows for us:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/firmware/ti_sci.c#n421

When i2c is not that frequently used, runtime pm disables the power
domain on our platform. As part of reset or power-off, when i2c is
invoked, it ends up calling into the firmware handler which (no
surprise), attempts to do the wrong thing (and rightly flagged by RCU).

We are in the middle of trying various combinations out to ensure we
are'nt messing things up.

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D