[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <8a4f8af5-c181-6e30-bfb5-be25f77a51a0@linaro.org>
Date: Thu, 15 Jun 2023 16:58:49 +0200
From: Konrad Dybcio <konrad.dybcio@...aro.org>
To: Sridharan S N <quic_sridsn@...cinc.com>, agross@...nel.org,
andersson@...nel.org, robh+dt@...nel.org,
krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2 2/2] arm64: dts: qcom: ipq9574: enable GPIO based LEDs
On 15.06.2023 16:53, Sridharan S N wrote:
> Add support for wlan-2g LED on GPIO 64.
>
> Signed-off-by: Sridharan S N <quic_sridsn@...cinc.com>
> ---
Same comments as on patch 1.
Konrad
> Changes in V2:
> - Updated commit message
>
> .../boot/dts/qcom/ipq9574-rdp-common.dtsi | 20 +++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi b/arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi
> index fd5326dc1773..25424cecd834 100644
> --- a/arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi
> @@ -34,6 +34,18 @@
> debounce-interval = <60>;
> };
> };
> +
> + leds {
> + compatible = "gpio-leds";
> + pinctrl-0 = <&gpio_leds_default>;
> + pinctrl-names = "default";
> +
> + led-0 {
> + gpios = <&tlmm 64 GPIO_ACTIVE_LOW>;
> + linux,default-trigger = "phy0tx";
> + default-state = "off";
> + };
> + };
> };
>
> &blsp1_spi0 {
> @@ -137,6 +149,14 @@
> drive-strength = <8>;
> bias-pull-up;
> };
> +
> + gpio_leds_default: gpio-leds-default-state {
> + pins = "gpio64";
> + function = "gpio";
> + drive-strength = <8>;
> + bias-pull-up;
> + };
> +
> };
>
> &xo_board_clk {
Powered by blists - more mailing lists