linux-kernel - Re: [PATCH] accel/qaic: Call DRM helper function to destroy prime GEM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <af6fb581-42c7-2619-82ce-8bd590ec629e@quicinc.com>
Date:   Thu, 15 Jun 2023 09:23:06 -0600
From:   Jeffrey Hugo <quic_jhugo@...cinc.com>
To:     Christian König <christian.koenig@....com>,
        <quic_carlv@...cinc.com>, <quic_pkanojiy@...cinc.com>,
        <sukrut.bellary@...ux.com>, <sumit.semwal@...aro.org>
CC:     <ogabbay@...nel.org>, <linux-arm-msm@...r.kernel.org>,
        <kernel-janitors@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <dri-devel@...ts.freedesktop.org>,
        <linaro-mm-sig@...ts.linaro.org>, <linux-media@...r.kernel.org>
Subject: Re: [PATCH] accel/qaic: Call DRM helper function to destroy prime GEM

On 6/15/2023 1:05 AM, Christian König wrote:
> 
> 
> Am 14.06.23 um 18:15 schrieb Jeffrey Hugo:
>> From: Pranjal Ramajor Asha Kanojiya <quic_pkanojiy@...cinc.com>
>>
>> smatch warning:
>>     drivers/accel/qaic/qaic_data.c:620 qaic_free_object() error:
>>         dereferencing freed memory 'obj->import_attach'
>>
>> obj->import_attach is detached and freed using dma_buf_detach().
>> But used after free to decrease the dmabuf ref count using
>> dma_buf_put().
>>
>> drm_prime_gem_destroy() handles this issue and performs the proper clean
>> up instead of open coding it in the driver.
>>
>> Fixes: ff13be830333 ("accel/qaic: Add datapath")
>> Reported-by: Sukrut Bellary <sukrut.bellary@...ux.com>
>> Closes: 
>> https://lore.kernel.org/all/20230610021200.377452-1-sukrut.bellary@linux.com/ 
>>
>> Suggested-by: Christian König <christian.koenig@....com>
>> Signed-off-by: Pranjal Ramajor Asha Kanojiya <quic_pkanojiy@...cinc.com>
>> Reviewed-by: Carl Vanderlip <quic_carlv@...cinc.com>
>> Reviewed-by: Jeffrey Hugo <quic_jhugo@...cinc.com>
>> Signed-off-by: Jeffrey Hugo <quic_jhugo@...cinc.com>
> 
> Reviewed-by: Christian König <christian.koenig@....com>

Thanks for the guidance and review!