linux-kernel - Re: [PATCH v2] arm64: dts: ti: k3-am62-main: Remove power-domains from crypto node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 15 Jun 2023 09:31:12 +0530
From:   Vignesh Raghavendra <vigneshr@...com>
To:     Kamlesh Gurudasani <kamlesh@...com>, Nishanth Menon <nm@...com>,
        Tero Kristo <kristo@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Jayesh Choudhary <j-choudhary@...com>
CC:     <linux-arm-kernel@...ts.infradead.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] arm64: dts: ti: k3-am62-main: Remove power-domains
 from crypto node



On 14/06/23 15:16, Kamlesh Gurudasani wrote:
> Only SYSFW has control of SA3UL power.
> From SYSFW 08.04.00.002, for security reasons, device ID for power
> management of SA3UL has been removed.
> 
> "power-domains" property in crypto node tries to access
> the SA3UL, for which it gets NACK and hence, SA3UL driver doesn't
> probe properly.
> 
> Fixes: 8af893654c02 ("arm64: dts: ti: k3-am62-main: Enable crypto accelerator")
> 
> Signed-off-by: Kamlesh Gurudasani <kamlesh@...com>
> ---
> v2 changes:
> -make commit message clearer
> ---
>  arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> index b3e4857bbbe4..18a6e9ffaf58 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> @@ -174,7 +174,6 @@ k3_reset: reset-controller {
>  	crypto: crypto@...00000 {
>  		compatible = "ti,am62-sa3ul";
>  		reg = <0x00 0x40900000 0x00 0x1200>;
> -		power-domains = <&k3_pds 70 TI_SCI_PD_SHARED>;


Per Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml this is a
required property. This would need binding update to make power-domains
optional for certain compatibles.

>  		#address-cells = <2>;
>  		#size-cells = <2>;
>  		ranges = <0x00 0x40900000 0x00 0x40900000 0x00 0x30000>;
> 
> ---
> base-commit: 53ab6975c12d1ad86c599a8927e8c698b144d669
> change-id: 20230614-sa3ul-cb4bd1bb4d08
> 
> Best regards,

-- 
Regards
Vignesh