linux-kernel - RE: [PATCH] checkpatch: Include GEM_BUG_xxx variant in the excluded check list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <IA1PR11MB64187D5665064B4E36DF6514C15BA@IA1PR11MB6418.namprd11.prod.outlook.com>
Date:   Thu, 15 Jun 2023 19:23:05 +0000
From:   "Ruhl, Michael J" <michael.j.ruhl@...el.com>
To:     David Hildenbrand <david@...hat.com>,
        Joe Perches <joe@...ches.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "apw@...onical.com" <apw@...onical.com>,
        "dwaipayanray1@...il.com" <dwaipayanray1@...il.com>,
        "lukas.bulwahn@...il.com" <lukas.bulwahn@...il.com>,
        "corbet@....net" <corbet@....net>
Subject: RE: [PATCH] checkpatch: Include GEM_BUG_xxx variant in the excluded
 check list

>-----Original Message-----
>From: David Hildenbrand <david@...hat.com>
>Sent: Thursday, June 15, 2023 11:28 AM
>To: Ruhl, Michael J <michael.j.ruhl@...el.com>; Joe Perches
><joe@...ches.com>; linux-kernel@...r.kernel.org; apw@...onical.com;
>dwaipayanray1@...il.com; lukas.bulwahn@...il.com; corbet@....net
>Subject: Re: [PATCH] checkpatch: Include GEM_BUG_xxx variant in the
>excluded check list
>
>On 15.06.23 17:04, Ruhl, Michael J wrote:
>>> -----Original Message-----
>>> From: Joe Perches <joe@...ches.com>
>>> Sent: Wednesday, June 14, 2023 9:47 PM
>>> To: Ruhl, Michael J <michael.j.ruhl@...el.com>; linux-
>kernel@...r.kernel.org;
>>> apw@...onical.com; dwaipayanray1@...il.com;
>lukas.bulwahn@...il.com;
>>> corbet@....net; david@...hat.com
>>> Subject: Re: [PATCH] checkpatch: Include GEM_BUG_xxx variant in the
>>> excluded check list
>>>
>>> On Wed, 2023-06-14 at 12:49 -0400, Michael J. Ruhl wrote:
>>>> GEM_BUG_ON is usually compiled as WARN.  You have to change to
>>>> debug configuration to get this to be BUG.
>>>>
>>>> checkpatch flags this a WARN level issue.
>>>>
>>>> Since this is a i915 local debug macro, allow its use in checkpatch.pl.
>>>>
>>>> Fixes: 69d517e6e210 ("checkpatch: warn on usage of VM_BUG_ON() and
>>> other BUG variants")
>>>
>>> Not a "Fixes", just an additional check
>>
>
>That was discussed when developing that patch:
>
>https://lore.kernel.org/linux-mm/87tu5vflld.fsf@intel.com/T/
>
>GEM_BUG_ON(
>-> Bad with CONFIG_DRM_I915_DEBUG_GEM_ONCE
>
>Just like VM_BUG_ON or CI_BUG_ON... that BUGs only with another kernel
>config on.
>
>So this is expected.

Hmm,

Ok.

Maybe next time.

M

>--
>Cheers,
>
>David / dhildenb