linux-kernel - Re: [PATCH] erofs: remove unnecessary goto

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 15 Jun 2023 12:20:37 +0800
From:   Jingbo Xu <jefflexu@...ux.alibaba.com>
To:     Yangtao Li <frank.li@...o.com>, Gao Xiang <xiang@...nel.org>,
        Chao Yu <chao@...nel.org>, Yue Hu <huyue2@...lpad.com>
Cc:     linux-erofs@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] erofs: remove unnecessary goto



On 6/15/23 11:45 AM, Yangtao Li wrote:
> It's redundant, let's remove it.
> 
> Signed-off-by: Yangtao Li <frank.li@...o.com>

Reviewed-by: Jingbo Xu <jefflexu@...ux.alibaba.com>


> ---
>  fs/erofs/super.c | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/fs/erofs/super.c b/fs/erofs/super.c
> index 811ab66d805e..f48ce692094d 100644
> --- a/fs/erofs/super.c
> +++ b/fs/erofs/super.c
> @@ -1016,10 +1016,8 @@ static int __init erofs_module_init(void)
>  					       sizeof(struct erofs_inode), 0,
>  					       SLAB_RECLAIM_ACCOUNT,
>  					       erofs_inode_init_once);
> -	if (!erofs_inode_cachep) {
> -		err = -ENOMEM;
> -		goto icache_err;
> -	}
> +	if (!erofs_inode_cachep)
> +		return -ENOMEM;
>  
>  	err = erofs_init_shrinker();
>  	if (err)
> @@ -1054,7 +1052,6 @@ static int __init erofs_module_init(void)
>  	erofs_exit_shrinker();
>  shrinker_err:
>  	kmem_cache_destroy(erofs_inode_cachep);
> -icache_err:
>  	return err;
>  }
>  

-- 
Thanks,
Jingbo