linux-kernel - Re: [patch 12/17] init: Invoke arch_cpu_finalize

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87sfas758t.ffs@tglx>
Date:   Fri, 16 Jun 2023 00:03:30 +0200
From:   Thomas Gleixner <tglx@...utronix.de>
To:     "Edgecombe, Rick P" <rick.p.edgecombe@...el.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Cc:     "chenhuacai@...nel.org" <chenhuacai@...nel.org>,
        "darwi@...utronix.de" <darwi@...utronix.de>,
        "linux-ia64@...r.kernel.org" <linux-ia64@...r.kernel.org>,
        "glaubitz@...sik.fu-berlin.de" <glaubitz@...sik.fu-berlin.de>,
        "Torvalds, Linus" <torvalds@...ux-foundation.org>,
        "chris@...kel.net" <chris@...kel.net>,
        "ysato@...rs.sourceforge.jp" <ysato@...rs.sourceforge.jp>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "thomas.lendacky@....com" <thomas.lendacky@....com>,
        "James.Bottomley@...senPartnership.com" 
        <James.Bottomley@...senPartnership.com>,
        "mpe@...erman.id.au" <mpe@...erman.id.au>,
        "kernel@...0n.name" <kernel@...0n.name>,
        "linux-sh@...r.kernel.org" <linux-sh@...r.kernel.org>,
        "dalias@...c.org" <dalias@...c.org>,
        "loongarch@...ts.linux.dev" <loongarch@...ts.linux.dev>,
        "linux@...linux.org.uk" <linux@...linux.org.uk>,
        "linux-m68k@...ts.linux-m68k.org" <linux-m68k@...ts.linux-m68k.org>,
        "nik.borisov@...e.com" <nik.borisov@...e.com>,
        "arnd@...db.de" <arnd@...db.de>,
        "anton.ivanov@...bridgegreys.com" <anton.ivanov@...bridgegreys.com>,
        "sparclinux@...r.kernel.org" <sparclinux@...r.kernel.org>,
        "richard@....at" <richard@....at>,
        "johannes@...solutions.net" <johannes@...solutions.net>,
        "linux-um@...ts.infradead.org" <linux-um@...ts.infradead.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "tsbogend@...ha.franken.de" <tsbogend@...ha.franken.de>,
        "linux-mips@...r.kernel.org" <linux-mips@...r.kernel.org>,
        "richard.henderson@...aro.org" <richard.henderson@...aro.org>,
        "geert@...ux-m68k.org" <geert@...ux-m68k.org>,
        "x86@...nel.org" <x86@...nel.org>
Subject: Re: [patch 12/17] init: Invoke arch_cpu_finalize_init() earlier

On Thu, Jun 15 2023 at 21:44, Rick P. Edgecombe wrote:
> On Wed, 2023-06-14 at 01:39 +0200, Thomas Gleixner wrote:
>> Fortunately none of the init calls between calibrate_delay() and
>> arch_cpu_finalize_init() is relevant for the functionality of
>> arch_cpu_finalize_init().
>> 
>
> Reviewed-by: Rick Edgecombe <rick.p.edgecombe@...el.com>
>
> I did my best to find a counterpoint to this statement. The only thing
> I found was that lockdep_init_task(&init_task) in fork_init() is now
> called after the spin_lock() usage in set_memory_4k().
>
> But AFAICT, that whole lockdep_init_task() call is unneeded because
> the fields it sets are already statically initialized.

Correct. The call there looks absolute pointless. Peter?