linux-kernel - Re: [PATCH v2 01/15] dt-bindings: display: mediatek: ethdr: Add compatible for MT8188

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 15 Jun 2023 05:51:09 +0000
From:   Shawn Sung (宋孝謙) 
        <Shawn.Sung@...iatek.com>
To:     "p.zabel@...gutronix.de" <p.zabel@...gutronix.de>,
        "matthias.bgg@...il.com" <matthias.bgg@...il.com>,
        "angelogioacchino.delregno@...labora.com" 
        <angelogioacchino.delregno@...labora.com>,
        "chunkuang.hu@...nel.org" <chunkuang.hu@...nel.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "krzysztof.kozlowski+dt@...aro.org" 
        <krzysztof.kozlowski+dt@...aro.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-mediatek@...ts.infradead.org" 
        <linux-mediatek@...ts.infradead.org>,
        Singo Chang (張興國) 
        <Singo.Chang@...iatek.com>,
        Jason-JH Lin (林睿祥) 
        <Jason-JH.Lin@...iatek.com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        Nancy Lin (林欣螢) <Nancy.Lin@...iatek.com>,
        Project_Global_Chrome_Upstream_Group 
        <Project_Global_Chrome_Upstream_Group@...iatek.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v2 01/15] dt-bindings: display: mediatek: ethdr: Add
 compatible for MT8188

Hi Angelo,
 
Yes, MT8188 ETHDR is fully compatible with MT8195, so we didn't add its
compatible name to the driver but just listed it in dt-bindings.
 
May I double check with you that
I see there is a short description regarding "items" object:
> # items is a list of possible values for the property. The number of
> # values is determined by the number of elements in the list.
> # Order in lists is significant, order in dicts is not
in https://docs.kernel.org/devicetree/bindings/writing-schema.html
 
So does the compatible has to be:
"mediatek,mt8188-disp-ethdr", "mediatek,mt8195-disp-
ethdr" rather than in reversed order?
 
However, I couldn't find any description mentions the order in
Documentation/devicetree/bindings/writing-schema.rst
Not sure if the order in "items" object does not matter after then.
 
Thanks,
Hsiao Chien Sung


On Wed, 2023-06-14 at 13:41 +0200, AngeloGioacchino Del Regno wrote:
>  	 
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>  Il 14/06/23 09:31, Hsiao Chien Sung ha scritto:
> > Add compatible name for MediaTek MT8188 ETHDR.
> > 
> > Signed-off-by: Hsiao Chien Sung <shawn.sung@...iatek.com>
> > ---
> >   .../bindings/display/mediatek/mediatek,ethdr.yaml           | 6
> +++++-
> >   1 file changed, 5 insertions(+), 1 deletion(-)
> > 
> > diff --git
> a/Documentation/devicetree/bindings/display/mediatek/mediatek,ethdr.y
> aml
> b/Documentation/devicetree/bindings/display/mediatek/mediatek,ethdr.y
> aml
> > index 801fa66ae615..677882348ede 100644
> > ---
> a/Documentation/devicetree/bindings/display/mediatek/mediatek,ethdr.y
> aml
> > +++
> b/Documentation/devicetree/bindings/display/mediatek/mediatek,ethdr.y
> aml
> > @@ -23,7 +23,11 @@ description:
> > 
> >   properties:
> >     compatible:
> > -    const: mediatek,mt8195-disp-ethdr
> > +    oneOf:
> > +      - const: mediatek,mt8195-disp-ethdr
> > +      - items:
> > +          - const: mediatek,mt8188-disp-ethdr
> > +          - const: mediatek,mt8195-disp-ethdr
> > 
> 
> Is MT8188's ETHDR fully compatible with MT8195's ETHDR?
> 
> If it is, you're not adding a mt8188 specific compatible string in
> the driver and
> this means that the devicetree will look like:
> 
> compatible = "mediatek,mt8195-disp-ethdr", "mediatek,mt8188-disp-
> ethdr"
> 
> ...so the proposed doc change works.
> 
> Reviewed-by: AngeloGioacchino Del Regno <
> angelogioacchino.delregno@...labora.com>
> 
> >     reg:
> >       maxItems: 7
> > --
> > 2.18.0
> > 
> 
>