linux-kernel - Re: [PATCH V2 8/8] perf test: Add test case for the standard perf stat output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAP-5=fVt+_taayKpj8_aQ6wnxMBCU8GrKmbfY-M01gOE=X=EUg@mail.gmail.com>
Date:   Wed, 14 Jun 2023 23:00:04 -0700
From:   Ian Rogers <irogers@...gle.com>
To:     kan.liang@...ux.intel.com
Cc:     acme@...nel.org, mingo@...hat.com, peterz@...radead.org,
        namhyung@...nel.org, jolsa@...nel.org, adrian.hunter@...el.com,
        linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org,
        ak@...ux.intel.com, eranian@...gle.com, ahmad.yasin@...el.com
Subject: Re: [PATCH V2 8/8] perf test: Add test case for the standard perf
 stat output

On Wed, Jun 14, 2023 at 5:18 PM <kan.liang@...ux.intel.com> wrote:
>
> From: Kan Liang <kan.liang@...ux.intel.com>
>
> Add a new test case to verify the standard perf stat output with
> different options.
>
> Signed-off-by: Kan Liang <kan.liang@...ux.intel.com>

Reviewed-by: Ian Rogers <irogers@...gle.com>

Thanks,
Ian

> ---
>  tools/perf/tests/shell/stat+std_output.sh | 108 ++++++++++++++++++++++
>  1 file changed, 108 insertions(+)
>  create mode 100755 tools/perf/tests/shell/stat+std_output.sh
>
> diff --git a/tools/perf/tests/shell/stat+std_output.sh b/tools/perf/tests/shell/stat+std_output.sh
> new file mode 100755
> index 000000000000..98cc3356a04a
> --- /dev/null
> +++ b/tools/perf/tests/shell/stat+std_output.sh
> @@ -0,0 +1,108 @@
> +#!/bin/bash
> +# perf stat STD output linter
> +# SPDX-License-Identifier: GPL-2.0
> +# Tests various perf stat STD output commands for
> +# default event and metricgroup
> +
> +set -e
> +
> +. $(dirname $0)/lib/stat_output.sh
> +
> +stat_output=$(mktemp /tmp/__perf_test.stat_output.std.XXXXX)
> +
> +event_name=(cpu-clock task-clock context-switches cpu-migrations page-faults cycles instructions branches branch-misses stalled-cycles-frontend stalled-cycles-backend)
> +event_metric=("CPUs utilized" "CPUs utilized" "/sec" "/sec" "/sec" "GHz" "insn per cycle" "/sec" "of all branches" "frontend cycles idle" "backend cycles idle")
> +
> +metricgroup_name=(TopdownL1 TopdownL2)
> +
> +cleanup() {
> +  rm -f "${stat_output}"
> +
> +  trap - EXIT TERM INT
> +}
> +
> +trap_cleanup() {
> +  cleanup
> +  exit 1
> +}
> +trap trap_cleanup EXIT TERM INT
> +
> +function commachecker()
> +{
> +       local -i cnt=0
> +       local prefix=1
> +
> +       case "$1"
> +       in "--interval")        prefix=2
> +       ;; "--per-thread")      prefix=2
> +       ;; "--system-wide-no-aggr")     prefix=2
> +       ;; "--per-core")        prefix=3
> +       ;; "--per-socket")      prefix=3
> +       ;; "--per-node")        prefix=3
> +       ;; "--per-die")         prefix=3
> +       ;; "--per-cache")       prefix=3
> +       esac
> +
> +       while read line
> +       do
> +               # Ignore initial "started on" comment.
> +               x=${line:0:1}
> +               [ "$x" = "#" ] && continue
> +               # Ignore initial blank line.
> +               [ "$line" = "" ] && continue
> +               # Ignore "Performance counter stats"
> +               x=${line:0:25}
> +               [ "$x" = "Performance counter stats" ] && continue
> +               # Ignore "seconds time elapsed" and break
> +               [[ "$line" == *"time elapsed"* ]] && break
> +
> +               main_body=$(echo $line | cut -d' ' -f$prefix-)
> +               x=${main_body%#*}
> +               # Check default metricgroup
> +               y=$(echo $x | tr -d ' ')
> +               [ "$y" = "" ] && continue
> +               for i in "${!metricgroup_name[@]}"; do
> +                       [[ "$y" == *"${metricgroup_name[$i]}"* ]] && break
> +               done
> +               [[ "$y" == *"${metricgroup_name[$i]}"* ]] && continue
> +
> +               # Check default event
> +               for i in "${!event_name[@]}"; do
> +                       [[ "$x" == *"${event_name[$i]}"* ]] && break
> +               done
> +
> +               [[ ! "$x" == *"${event_name[$i]}"* ]] && {
> +                       echo "Unknown event name in $line" 1>&2
> +                       exit 1;
> +               }
> +
> +               # Check event metric if it exists
> +               [[ ! "$main_body" == *"#"* ]] && continue
> +               [[ ! "$main_body" == *"${event_metric[$i]}"* ]] && {
> +                       echo "wrong event metric. expected ${event_metric[$i]} in $line" 1>&2
> +                       exit 1;
> +               }
> +       done < "${stat_output}"
> +       return 0
> +}
> +
> +perf_cmd="-o ${stat_output}"
> +
> +skip_test=$(check_for_topology)
> +check_no_args "STD" "$perf_cmd"
> +check_system_wide "STD" "$perf_cmd"
> +check_interval "STD" "$perf_cmd"
> +check_per_thread "STD" "$perf_cmd"
> +check_per_node "STD" "$perf_cmd"
> +if [ $skip_test -ne 1 ]
> +then
> +       check_system_wide_no_aggr "STD" "$perf_cmd"
> +       check_per_core "STD" "$perf_cmd"
> +       check_per_cache_instance "STD" "$perf_cmd"
> +       check_per_die "STD" "$perf_cmd"
> +       check_per_socket "STD" "$perf_cmd"
> +else
> +       echo "[Skip] Skipping tests for system_wide_no_aggr, per_core, per_die and per_socket since socket id exposed via topology is invalid"
> +fi
> +cleanup
> +exit 0
> --
> 2.35.1
>