linux-kernel - Re: [PATCH] clk: pxa: fix NULL pointer dereference in pxa3xx_clk_update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8eceb50391ff83f598e16e0cb371fdb0.sboyd@kernel.org>
Date:   Wed, 14 Jun 2023 17:22:21 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     Arnd Bergmann <arnd@...nel.org>,
        Michael Turquette <mturquette@...libre.com>
Cc:     Arnd Bergmann <arnd@...db.de>, stable@...r.kernel.org,
        kernel test robot <lkp@...el.com>,
        Nathan Chancellor <nathan@...nel.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Tom Rix <trix@...hat.com>,
        Robert Jarzmik <robert.jarzmik@...e.fr>,
        linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org,
        llvm@...ts.linux.dev
Subject: Re: [PATCH] clk: pxa: fix NULL pointer dereference in pxa3xx_clk_update_accr

Quoting Arnd Bergmann (2023-05-11 03:58:33)
> From: Arnd Bergmann <arnd@...db.de>
> 
> sparse points out an embarrasing bug in an older patch of mine,
> which uses the register offset instead of an __iomem pointer:
> 
> drivers/clk/pxa/clk-pxa3xx.c:167:9: sparse: sparse: Using plain integer as NULL pointer
> 
> Unlike sparse, gcc and clang ignore this bug and fail to warn
> because a literal '0' is considered a valid representation of
> a NULL pointer.
> 
> Fixes: 3c816d950a49 ("ARM: pxa: move clk register definitions to driver")
> Cc: stable@...r.kernel.org
> Reported-by: kernel test robot <lkp@...el.com>
> Link: https://lore.kernel.org/oe-kbuild-all/202305111301.RAHohdob-lkp@intel.com/
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---

Applied to clk-fixes