linux-kernel - Re: [PATCH] ALSA: ac97: Fix possible NULL dereference in snd_ac97

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87r0qd8bwv.wl-tiwai@suse.de>
Date:   Thu, 15 Jun 2023 08:41:52 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     Su Hui <suhui@...china.com>
Cc:     Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
        Arnd Bergmann <arnd@...db.de>, maciej.szmigiero@...cle.com,
        yangyingliang@...wei.com, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] ALSA: ac97: Fix possible NULL dereference in snd_ac97_mixer

On Thu, 15 Jun 2023 04:17:32 +0200,
Su Hui wrote:
> 
> smatch error:
> sound/pci/ac97/ac97_codec.c:2354 snd_ac97_mixer() error:
> we previously assumed 'rac97' could be null (see line 2072)
> 
> remove redundant assignment, return error if rac97 is NULL.
> 
> Fixes: da3cec35dd3c ("ALSA: Kill snd_assert() in sound/pci/*")
> Signed-off-by: Su Hui <suhui@...china.com>

Thanks, applied.


Takashi