linux-kernel - Re: [PATCH 5/9] MIPS: DTS: CI20: Misc. cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 15 Jun 2023 09:01:02 +0200
From:   "H. Nikolaus Schaller" <hns@...delico.com>
To:     Paul Cercueil <paul@...pouillou.net>
Cc:     Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>, linux-mips@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        list@...ndingux.net
Subject: Re: [PATCH 5/9] MIPS: DTS: CI20: Misc. cleanups

Please find a more useful subject.

> Am 04.06.2023 um 16:56 schrieb Paul Cercueil <paul@...pouillou.net>:
> 
> - Use the standard "ecc-engine" property instead of the custom
> "ingenic,bch-controller" to get a handle to the BCH controller.
> 
> - Respect cell sizes in the Ethernet controller node.
> 
> - Use proper macro for interrupt type instead of hardcoding magic
>  values.
> 
> Signed-off-by: Paul Cercueil <paul@...pouillou.net>
> ---
> arch/mips/boot/dts/ingenic/ci20.dts | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/mips/boot/dts/ingenic/ci20.dts b/arch/mips/boot/dts/ingenic/ci20.dts
> index 7f6e7a4e3915..b7dbafa1f85d 100644
> --- a/arch/mips/boot/dts/ingenic/ci20.dts
> +++ b/arch/mips/boot/dts/ingenic/ci20.dts
> @@ -356,7 +356,7 @@ nandc: nand-controller@1 {
> 		#address-cells = <1>;
> 		#size-cells = <0>;
> 
> -		ingenic,bch-controller = <&bch>;
> +		ecc-engine = <&bch>;
> 
> 		ingenic,nemc-tAS = <10>;
> 		ingenic,nemc-tAH = <5>;
> @@ -422,8 +422,8 @@ dm9000@6 {
> 		pinctrl-names = "default";
> 		pinctrl-0 = <&pins_nemc_cs6>;
> 
> -		reg = <6 0 1   /* addr */
> -		       6 2 1>; /* data */
> +		reg = <6 0 1>, /* addr */
> +		      <6 2 1>; /* data */
> 
> 		ingenic,nemc-tAS = <15>;
> 		ingenic,nemc-tAH = <10>;
> @@ -435,7 +435,7 @@ dm9000@6 {
> 		vcc-supply = <&eth0_power>;
> 
> 		interrupt-parent = <&gpe>;
> -		interrupts = <19 4>;
> +		interrupts = <19 IRQ_TYPE_EDGE_RISING>;
> 
> 		nvmem-cells = <&eth0_addr>;
> 		nvmem-cell-names = "mac-address";


For better bisecting it would be helpful to split this into 3 patches.

And they are not really related to WiFi/Bluetooth.