linux-kernel - Re: [PATCH v4 1/1] dax: enable dax fault handler to report VM_FAULT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <80bea2b0-db8a-0441-e7c4-051898729101@oracle.com>
Date:   Wed, 14 Jun 2023 17:49:52 -0700
From:   Jane Chu <jane.chu@...cle.com>
To:     Dan Williams <dan.j.williams@...el.com>, vishal.l.verma@...el.com,
        dave.jiang@...el.com, ira.weiny@...el.com, willy@...radead.org,
        viro@...iv.linux.org.uk, brauner@...nel.org,
        nvdimm@...ts.linux.dev, linux-kernel@...r.kernel.org,
        linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH v4 1/1] dax: enable dax fault handler to report
 VM_FAULT_HWPOISON

On 6/8/2023 8:16 PM, Dan Williams wrote:
[..]
>>   
>> +static inline int dax_mem2blk_err(int err)
>> +{
>> +	return (err == -EHWPOISON) ? -EIO : err;
>> +}
> 
> I think it is worth a comment on this function to indicate where this
> helper is *not* used. I.e. it's easy to grep for where the error code is
> converted for file I/O errors, but the subtlety of when the
> dax_direct_acces() return value is not translated for fault handling
> deserves a comment when we wonder why this function exists in a few
> years time.

Good point!  v5 coming up next.

thanks!
-jane