linux-kernel - Re: [PATCH] selftests/ptp: Fix timestamp printf format for PTP_SYS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALs4sv2+nb3i8VQKNsqLzrCR0Sq6oHPwrzxYdeAaMVX+1-Z+VA@mail.gmail.com>
Date:   Thu, 15 Jun 2023 15:13:27 +0530
From:   Pavan Chebbi <pavan.chebbi@...adcom.com>
To:     Alex Maftei <alex.maftei@....com>
Cc:     richardcochran@...il.com, shuah@...nel.org,
        linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH] selftests/ptp: Fix timestamp printf format for PTP_SYS_OFFSET

On Thu, Jun 15, 2023 at 2:05 PM Alex Maftei <alex.maftei@....com> wrote:
>
> Previously, timestamps were printed using "%lld.%u" which is incorrect
> for nanosecond values lower than 100,000,000 as they're fractional
> digits, therefore leading zeros are meaningful.
>
> This patch changes the format strings to "%lld.%09u" in order to add
> leading zeros to the nanosecond value.
>
> Fixes: 568ebc5985f5 ("ptp: add the PTP_SYS_OFFSET ioctl to the testptp program")
> Fixes: 4ec54f95736f ("ptp: Fix compiler warnings in the testptp utility")
> Fixes: 6ab0e475f1f3 ("Documentation: fix misc. warnings")
> Signed-off-by: Alex Maftei <alex.maftei@....com>
> ---
>  tools/testing/selftests/ptp/testptp.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>

Change looks good but can you mark this for "net" correctly and get
CI/sanity checks done.

> diff --git a/tools/testing/selftests/ptp/testptp.c b/tools/testing/selftests/ptp/testptp.c
> index 198ad5f32187..cfa9562f3cd8 100644
> --- a/tools/testing/selftests/ptp/testptp.c
> +++ b/tools/testing/selftests/ptp/testptp.c
> @@ -502,11 +502,11 @@ int main(int argc, char *argv[])
>                         interval = t2 - t1;
>                         offset = (t2 + t1) / 2 - tp;
>
> -                       printf("system time: %lld.%u\n",
> +                       printf("system time: %lld.%09u\n",
>                                 (pct+2*i)->sec, (pct+2*i)->nsec);
> -                       printf("phc    time: %lld.%u\n",
> +                       printf("phc    time: %lld.%09u\n",
>                                 (pct+2*i+1)->sec, (pct+2*i+1)->nsec);
> -                       printf("system time: %lld.%u\n",
> +                       printf("system time: %lld.%09u\n",
>                                 (pct+2*i+2)->sec, (pct+2*i+2)->nsec);
>                         printf("system/phc clock time offset is %" PRId64 " ns\n"
>                                "system     clock time delay  is %" PRId64 " ns\n",
> --
> 2.28.0
>
>

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4209 bytes)