[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <44ebcc5e-d424-0e5f-1384-19397a0c36ae@linaro.org>
Date: Thu, 15 Jun 2023 12:12:24 +0200
From: neil.armstrong@...aro.org
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>,
Bjorn Andersson <andersson@...nel.org>,
Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
Liam Girdwood <lgirdwood@...il.com>,
Mark Brown <broonie@...nel.org>,
Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
linux-arm-msm@...r.kernel.org, linux-usb@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 2/2] usb: typec: add support for the nb7vpq904m Type-C
Linear Redriver
On 15/06/2023 11:47, Greg Kroah-Hartman wrote:
> On Tue, Jun 13, 2023 at 04:50:08PM +0200, neil.armstrong@...aro.org wrote:
>> From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
>>
>> Add support for the ON Semiconductor NB7VPQ904M Type-C USB SuperSpeed
>> and DisplayPort ALT Mode Linear Redriver chip found on some devices
>> with a Type-C port.
>>
>> The redriver compensates ultra High-Speeed DisplayPort and USB
>> Super Speed signal integrity losses mainly due to PCB & transmission
>> cables.
>>
>> The redriver doesn't support SuperSpeed lines swapping, but
>> can support Type-C SBU lines swapping.
>>
>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
>> Signed-off-by: Neil Armstrong <neil.armstrong@...aro.org>
>> ---
>> drivers/usb/typec/mux/Kconfig | 8 +
>> drivers/usb/typec/mux/Makefile | 1 +
>> drivers/usb/typec/mux/nb7vpq904m.c | 529 +++++++++++++++++++++++++++++++++++++
>> 3 files changed, 538 insertions(+)
>
> I get the following build error on my system with this applied:
>
> CC [M] drivers/usb/typec/mux/nb7vpq904m.o
> drivers/usb/typec/mux/nb7vpq904m.c: In function ‘nb7vpq904m_register_bridge’:
> drivers/usb/typec/mux/nb7vpq904m.c:327:20: error: ‘struct drm_bridge’ has no member named ‘of_node’
> 327 | nb7->bridge.of_node = nb7->client->dev.of_node;
> | ^
>
>
> What went wrong?
DRM bridge attach should be protected by #ifdef CONFIG_OF aswell, I'll send a v4 with such fix.
Thanks for the report,
Neil
>
> thanks,
>
> greg k-h
Powered by blists - more mailing lists